Skip to content

[bambulab] Enable camera only for local mode #19374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lsiepel merged 1 commit into from
Sep 25, 2025
Merged

[bambulab] Enable camera only for local mode #19374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions ....openhab.binding.bambulab/src/main/java/org/openhab/binding/bambulab/internal/Camera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import static java.nio.charset.StandardCharsets.UTF_8;
import static org.openhab.binding.bambulab.internal.BambuLabBindingConstants.NO_CAMERA_CERT;
import static org.openhab.binding.bambulab.internal.BambuLabBindingConstants.PrinterChannel.*;
import static org.openhab.binding.bambulab.internal.PrinterConfiguration.CLOUD_MODE_HOSTNAME;
import static org.openhab.binding.bambulab.internal.PrinterConfiguration.Series.X;
import static org.openhab.core.library.types.OnOffType.*;
import static org.openhab.core.thing.ThingStatus.*;
Expand Down Expand Up @@ -57,8 +58,12 @@ class Camera implements AutoCloseable {
void handleCommand(OnOffType command) {
if (this.config.series == X) {
logger.warn("Bambulab binding does not support camera for X series!");
thingHandler.updateState(CHANNEL_CAMERA_RECORD.getName(), OFF);
thingHandler.updateState(CHANNEL_CAMERA_IMAGE.getName(), UNDEF);
turnOffChannels();
return;
}
if (CLOUD_MODE_HOSTNAME.equalsIgnoreCase(this.config.hostname)) {
logger.warn("Bambulab binding does not support camera for cloud mode!");
turnOffChannels();
return;
}
close();
Expand All @@ -80,8 +85,7 @@ void handleCommand(OnOffType command) {
this.cameraFuture = thingHandler.getScheduler().submit(() -> job(camera));
} catch (Exception e) {
logger.debug("Cannot connect to camera!", e);
thingHandler.updateState(CHANNEL_CAMERA_RECORD.getName(), OFF);
thingHandler.updateState(CHANNEL_CAMERA_IMAGE.getName(), UNDEF);
turnOffChannels();
thingHandler.updateStatus(OFFLINE, COMMUNICATION_ERROR,
"@text/printer.handler.init.cannotConnectCamera[\"%s\"]".formatted(e.getLocalizedMessage()));
return;
Expand All @@ -94,6 +98,11 @@ void handleCommand(OnOffType command) {
thingHandler.updateStatus(ONLINE);
}

private void turnOffChannels() {
thingHandler.updateState(CHANNEL_CAMERA_RECORD.getName(), OFF);
thingHandler.updateState(CHANNEL_CAMERA_IMAGE.getName(), UNDEF);
}

private void job(TlsCamera camera) {
try (camera) {
for (var iterator = camera.iterator(); iterator.hasNext() && !interrupted();) {
Expand All @@ -109,8 +118,7 @@ private void job(TlsCamera camera) {
logger.debug("Generic exception occurred", e);
} finally {
logger.debug("The camera has no more elements, turning off the image channel");
thingHandler.updateState(CHANNEL_CAMERA_RECORD.getName(), OFF);
thingHandler.updateState(CHANNEL_CAMERA_IMAGE.getName(), UNDEF);
turnOffChannels();
}
}

Expand Down