[sonos] Remove unexpected XML tag added by backport of #19162 in 4.3.x #19264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in 4.3.x Related to openhab#19162 XML tag semantic-equipment-tag was introduced in 5.0 and is not supported in 4.3. Signed-off-by: Laurent Garnier <[email protected]>
Contributor
Author
|
This is a PR against 4.3.x branch to be included in next 4.3 patch. It was reported that the Sonos binding is not starting in version 4.3.7. |
Contributor
Author
|
Why adding the milestone 5.1 as it is a PR only for 4.3.x branch ? |
Contributor
It was part of the 5.1 backport, it also has the regression label. If not mistaken it will now show up correctly in thre release notes for 4.3.8 and not in 5.1. But please advice if this is wrong. I already notes to myself to keep an eye on the release notes to be sure this ends up as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #19162
XML tag semantic-equipment-tag was introduced in 5.0 and is not supported in 4.3.