Skip to content

[ecoflow] Fix labeling of 'supply priority' enum values #19241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lsiepel merged 1 commit into from
Aug 27, 2025
Merged

[ecoflow] Fix labeling of 'supply priority' enum values #19241

lsiepel merged 1 commit into from
Aug 27, 2025
+4 −2

Conversation

@maniac103
Copy link
Contributor

@maniac103 maniac103 commented Aug 25, 2025

Fixes #19235

lsiepel
lsiepel approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Double check; are these labels updated without upgrade instructions? I'm just not sure for these options. If not, upgrade instructions would be needed.

@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Aug 27, 2025
@maniac103
Copy link
Contributor Author

maniac103 commented Aug 27, 2025

Double check; are these labels updated without upgrade instructions?

Just did, seems like it works:

  • Started OH with old binding version
  • Created thing for API + PowerStream
  • Verified power priority value was '@text/...'
  • Installed fixed binding version
  • Verified power priority shows correct string

@lsiepel lsiepel merged commit 5e5a0a4 into openhab:main Aug 27, 2025
3 checks passed
@lsiepel lsiepel added this to the 5.1 milestone Aug 27, 2025
rogrun pushed a commit to rogrun/openhab-addons that referenced this pull request Sep 3, 2025
@maniac103 @rogrun
[ecoflow] Fix labeling of 'supply priority' enum values (openhab#19241)
6c81900 
Fixes openhab#19235

Signed-off-by: Danny Baumann <[email protected]>
rogrun pushed a commit to rogrun/openhab-addons that referenced this pull request Sep 3, 2025
@maniac103 @rogrun
[ecoflow] Fix labeling of 'supply priority' enum values (openhab#19241)
38f2a49 
Fixes openhab#19235

Signed-off-by: Danny Baumann <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Sep 6, 2025
@maniac103
[ecoflow] Fix labeling of 'supply priority' enum values (openhab#19241)
1803150 
Fixes openhab#19235

Signed-off-by: Danny Baumann <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 15, 2025
@maniac103 @pgfeller
[ecoflow] Fix labeling of 'supply priority' enum values (openhab#19241)
c323d53 
Fixes openhab#19235

Signed-off-by: Danny Baumann <[email protected]>
DrRSatzteil pushed a commit to DrRSatzteil/openhab-addons that referenced this pull request Oct 11, 2025
@maniac103 @DrRSatzteil
[ecoflow] Fix labeling of 'supply priority' enum values (openhab#19241)
cece01e 
Fixes openhab#19235

Signed-off-by: Danny Baumann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees

No one assigned

Labels

bug An unexpected problem or unintended behavior of an add-on

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

[ecoflow] Missing text for ecoflow.supply-priority

2 participants

@maniac103 @lsiepel