[avmfritz] Fix boost and window open modes #19118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Collaborator
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/fritz-binding-dect302-smartthermo302/165280/11 |
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Collaborator
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/fritz-binding-dect302-smartthermo302/165280/30 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with boost and window open mode detection in the AVM Fritz binding for thermostats. The fix addresses two core problems: BigDecimal comparison issues where scale differences caused incorrect equality checks, and logic precedence where boost/window open states were evaluated after other modes.
- Replaced
BigDecimal.equals()withBigDecimal.compareTo()to handle scale differences correctly - Reordered evaluation logic to prioritize boost and window open modes
- Added comprehensive test coverage for the fixed functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| HeatingModel.java | Fixed BigDecimal comparisons and reordered mode evaluation logic to properly detect boost and window open states |
| HeatingModelTest.java | Added test cases to verify boost and window open mode detection works correctly |
cweitkamp
approved these changes
Aug 14, 2025
Contributor
cweitkamp
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for fixing. Makes sense to rearrange the order of heating mode determination.
lsiepel
pushed a commit
that referenced
this pull request
Aug 14, 2025
* fix boost and window open modes Signed-off-by: Andrew Fiddian-Green <[email protected]>
lsiepel
pushed a commit
that referenced
this pull request
Aug 14, 2025
* fix boost and window open modes Signed-off-by: Andrew Fiddian-Green <[email protected]>
rogrun
pushed a commit
to rogrun/openhab-addons
that referenced
this pull request
Sep 3, 2025
* fix boost and window open modes Signed-off-by: Andrew Fiddian-Green <[email protected]>
rogrun
pushed a commit
to rogrun/openhab-addons
that referenced
this pull request
Sep 3, 2025
* fix boost and window open modes Signed-off-by: Andrew Fiddian-Green <[email protected]>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Sep 6, 2025
* fix boost and window open modes Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for https://community.openhab.org/t/fritz-binding-dect302-smartthermo302/165280/1
Fixes #17554
Consider backporting to v4.3.x
Tip for reviewer: there seems to have been two issues
BigDecimal.equals()depends on the scale of the two values .. so1.00is not the same as1.0. => The code has been changed to useBigDecimal.compareTo()which does not depend on scale.Jar files for testing
Test result:
Signed-off-by: Andrew Fiddian-Green [email protected]