[mercedesme] Improve HTTP 429 handling and implement new authorization flow #19099

weymann · 2025-08-02T16:30:53Z

Beginning of July forum members reports issue that MercedesMe Account is going OFFLINE with HTTP 429 response for websocket. Issue doesn't recover by itsself! User needs to disbale Account for several hours to get it running again!

Since approx 2 weeks I recieved positive results, with some fixing of minor issues.

I vote to bring this PR into the next patch release to resolve this blockage

Root cause:
Mercedes introduced some throttling mechanism which prevents opening the websocket druing the day. Mechanism isn't clear but together with HA Mercedes developer we came with the following idea:

data is now polled with refreshInterval using REST API - unfrequent updates
only if driving or charging state is recognized open websocket - frequent updates
if charging / driving ended switch back to REST API calls

New authorizaion flow
On top of the throttling Mercedes introduced again a new quite complicated authorization method.

These two changes

update strategy plus
new authorization flow

are inside this PR. Other changes are refactoring to structure api in authorization, REST API and websocket.

Copilot

Pull Request Overview

This PR implements HTTP 429 handling and a new authorization flow for the MercedesMe binding to address throttling issues that cause accounts to go offline. The changes include a dynamic update strategy that switches between REST API polling and websocket connections based on vehicle activity, plus a completely new authorization flow using user credentials instead of refresh tokens.

Key changes:

Replaced refresh token authentication with email/password login flow
Implemented adaptive update strategy (REST polling vs websocket based on vehicle activity)
Restructured API architecture with separate Authorization, RestApi, and Websocket classes

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
bridge-config.xml	Replaced refreshToken parameter with password parameter
AccountConfiguration.java	Updated configuration to use password instead of refreshToken
AccountHandler.java	Refactored to use new API structure and adaptive update strategy
Authorization.java	New class implementing OAuth2 login flow with email/password
RestApi.java	New class for REST API calls separated from websocket functionality
Websocket.java	Refactored websocket handling extending RestApi
Utils.java	Added query parameter parsing and updated server selection logic
Test files	Updated to work with new authentication flow and API structure

Comments suppressed due to low confidence (1)

bundles/org.openhab.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/utils/Utils.java:616

[nitpick] The parameter name 'query' is ambiguous. Consider renaming it to 'queryString' to clearly indicate it represents the query portion of a URL.

    public static Map<String, String> getQueryParams(String query) {

...ab.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/utils/Utils.java

...ding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/api/Authorization.java

....binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/api/Websocket.java

jlaur

Many thanks for the extensive fix. I have added a few comments.

I don't know if this was brought up before, but have you investigated if it might be possible to use the standard OAuth2 implementation in core? See https://www.openhab.org/javadoc/latest/org/openhab/core/auth/client/oauth2/package-summary

...ab.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/utils/Utils.java

...ding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/api/Authorization.java

jlaur · 2025-08-03T10:38:51Z

...ding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/api/Authorization.java

+            listener.onAccessTokenResponse(token);
+        } catch (InterruptedException | TimeoutException | ExecutionException | UnsupportedEncodingException
+                | JsonSyntaxException e) {
+            logger.info("Failed to refresh token {}", e.getMessage());


Should this be propagated to the user as a Thing status description?

I wouldn't do at this location. If a data call or websocket start fails with invalid token AccountHandler tries to recover the situation with a new login. If this fails then it's time to present OFFLINE status.

I guess it will be offline until it successfully recovers then? It could be offline with text "Refresh token expired, attempting relogin" or similar. This would make it more visible for users not checking logs, especially in cases where it doesn't succeed. Anyway, this is minor and you can also choose to leave it as is.

...ding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/api/Authorization.java

bundles/org.openhab.binding.mercedesme/README.md

weymann · 2025-08-06T23:29:48Z

I don't know if this was brought up before, but have you investigated if it might be possible to use the standard OAuth2 implementation in core? See https://www.openhab.org/javadoc/latest/org/openhab/core/auth/client/oauth2/package-summary

Yes, it was used in early versions before Mercedes presented more and more fancy auth methods. Look into Authorization.java and you'll see 6 requests are needed to finally get a token. Mercedes drifted away from OAuth2 to make it as hard as possible to use the car data without using their app.

Signed-off-by: Bernd Weymann <[email protected]> 429 recovery initial version Signed-off-by: Bernd Weymann <[email protected]> switch to pull requests Signed-off-by: Bernd Weymann <[email protected]> new update strategy Signed-off-by: Bernd Weymann <[email protected]> new update strategy Signed-off-by: Bernd Weymann <[email protected]> community test version Signed-off-by: Bernd Weymann <[email protected]> fix copilot findings AccountHandler Signed-off-by: Bernd Weymann <[email protected]>

Signed-off-by: Bernd Weymann <[email protected]>

Signed-off-by: Bernd Weymann <[email protected]> catch JSON Exception decoding stored toekn Signed-off-by: Bernd Weymann <[email protected]>

Signed-off-by: Bernd Weymann <[email protected]>

Signed-off-by: Bernd Weymann <[email protected]> junit test adaptions Signed-off-by: Bernd Weymann <[email protected]> junit test adaptions Signed-off-by: Bernd Weymann <[email protected]>

Signed-off-by: Bernd Weymann <[email protected]>

weymann · 2025-08-11T18:28:39Z

@jlaur just check the last open comment and if you're fine with that let's merge.

bundles/org.openhab.binding.mercedesme/README.md

bundles/org.openhab.binding.mercedesme/src/main/resources/OH-INF/i18n/mercedesme.properties

....binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/api/Websocket.java

Signed-off-by: Jacob Laursen <[email protected]>

jlaur

LGTM, thanks. I resolved two very minor comments so this can make it into the upcoming 5.0.1 patch release.

…n flow (#19099) Signed-off-by: Bernd Weymann <[email protected]>

…n flow (openhab#19099) Signed-off-by: Bernd Weymann <[email protected]>

…n flow (openhab#19099) Signed-off-by: Bernd Weymann <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

lsiepel requested a review from Copilot August 2, 2025 19:35

lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Aug 2, 2025

Copilot AI reviewed Aug 2, 2025

View reviewed changes

jlaur requested changes Aug 3, 2025

View reviewed changes

weymann force-pushed the mercedesme/authorization-429 branch from e6e489a to 65424b0 Compare August 7, 2025 15:09

weymann added 8 commits August 7, 2025 17:15

OH5 changes

abc7e62

Signed-off-by: Bernd Weymann <[email protected]>

catch JSON Exception decoding stored token

e693438

Signed-off-by: Bernd Weymann <[email protected]>

catch JSON Exception during init

fcd33a4

Signed-off-by: Bernd Weymann <[email protected]> catch JSON Exception decoding stored toekn Signed-off-by: Bernd Weymann <[email protected]>

handle binding errors

0981b93

Signed-off-by: Bernd Weymann <[email protected]>

fix copilot and easy review comments

6011dcc

Signed-off-by: Bernd Weymann <[email protected]>

junit test adaptions

5aa6dfa

Signed-off-by: Bernd Weymann <[email protected]> junit test adaptions Signed-off-by: Bernd Weymann <[email protected]> junit test adaptions Signed-off-by: Bernd Weymann <[email protected]>

http request changes

caf174e

Signed-off-by: Bernd Weymann <[email protected]>

weymann force-pushed the mercedesme/authorization-429 branch from 65424b0 to caf174e Compare August 7, 2025 15:16

weymann requested a review from jlaur August 11, 2025 18:27

jlaur reviewed Aug 18, 2025

View reviewed changes

bundles/org.openhab.binding.mercedesme/README.md Outdated Show resolved Hide resolved

jlaur reviewed Aug 18, 2025

View reviewed changes

bundles/org.openhab.binding.mercedesme/src/main/resources/OH-INF/i18n/mercedesme.properties Outdated Show resolved Hide resolved

jlaur reviewed Aug 18, 2025

View reviewed changes

....binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/api/Websocket.java Outdated Show resolved Hide resolved

Apply suggestions from code review

fe8e7bf

Signed-off-by: Jacob Laursen <[email protected]>

jlaur approved these changes Aug 18, 2025

View reviewed changes

jlaur changed the title ~~[mercedesme] HTTP 429 handling and new authorization flow~~ [mercedesme] Improve HTTP 429 handling and implement new authorization flow Aug 18, 2025

jlaur merged commit 5bab3f4 into openhab:main Aug 18, 2025
2 checks passed

jlaur added this to the 5.1 milestone Aug 18, 2025

jlaur pushed a commit that referenced this pull request Aug 18, 2025

[mercedesme] Improve HTTP 429 handling and implement new authorizatio…

78dd7bc

…n flow (#19099) Signed-off-by: Bernd Weymann <[email protected]>

jlaur added the backported A PR that has been cherry-picked to a patch release branch label Aug 18, 2025

weymann deleted the mercedesme/authorization-429 branch August 29, 2025 14:27

rogrun pushed a commit to rogrun/openhab-addons that referenced this pull request Sep 3, 2025

[mercedesme] Improve HTTP 429 handling and implement new authorizatio…

9aabffb

…n flow (openhab#19099) Signed-off-by: Bernd Weymann <[email protected]>

rogrun pushed a commit to rogrun/openhab-addons that referenced this pull request Sep 3, 2025

[mercedesme] Improve HTTP 429 handling and implement new authorizatio…

ec838ef

…n flow (openhab#19099) Signed-off-by: Bernd Weymann <[email protected]>

Uh oh!

[mercedesme] Improve HTTP 429 handling and implement new authorization flow #19099

[mercedesme] Improve HTTP 429 handling and implement new authorization flow #19099

Uh oh!

Conversation

weymann commented Aug 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jlaur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jlaur Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

weymann Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

jlaur Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

weymann commented Aug 6, 2025

Uh oh!

weymann commented Aug 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jlaur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jlaur Aug 16, 2025 •

edited

Loading