Skip to content

Chart page: Fix wrong height inside popups, popovers & sheets on iOS #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
florian-h05 merged 1 commit into from
Jan 8, 2025
Merged

Chart page: Fix wrong height inside popups, popovers & sheets on iOS #2991

florian-h05 merged 1 commit into from
Jan 8, 2025

Conversation

@florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Jan 8, 2025 •
edited
Loading

@florian-h05 florian-h05 marked this pull request as ready for review January 8, 2025 17:23
@florian-h05 florian-h05 requested a review from ghys as a code owner January 8, 2025 17:23
@relativeci
Copy link

relativeci bot commented Jan 8, 2025

#2661 Bundle Size — 10.97MiB (~+0.01%).

4a5fe28(current) vs aa572b7 main#2660(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2661		      Baseline
#2660
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 17.68% 18.34%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2950 2950
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.78% 1.78%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2661		      Baseline
#2660
No change  JS 9.19MiB 9.19MiB
Regression  CSS 866.78KiB (+0.06%) 866.3KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis report Branch florian-h05:chart-ios-popup Project dashboard

Generated by RelativeCI Documentation Report issue

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Jan 8, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Jan 8, 2025
@florian-h05 florian-h05 merged commit 7034ad9 into openhab:main Jan 8, 2025
5 checks passed
@florian-h05 florian-h05 deleted the chart-ios-popup branch January 8, 2025 17:33
florian-h05 added a commit that referenced this pull request Jan 8, 2025
@florian-h05
Chart page: Fix wrong height inside popups, popovers & sheets on iOS (#…
6dc0738 
…2991)

Fixes known limitation from #2717.
Reported on the community:
https://community.openhab.org/t/openhab-4-3-release-discussion/160888/155?u=florian-h05

Signed-off-by: Florian Hotze <[email protected]>
(cherry picked from commit 7034ad9)
@florian-h05 florian-h05 added the backported A PR that has been cherry-picked to a patch release branch label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ghys ghys Awaiting requested review from ghys ghys is a code owner

Assignees

No one assigned

Labels

backported A PR that has been cherry-picked to a patch release branch bug Something isn't working main ui Main UI

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

1 participant

@florian-h05