Adds dataframe #259
Merged
Adds dataframe #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae9d1e5 to
d24b4ac
Compare
mginzbur
reviewed
Sep 28, 2022
b65b28e to
53c0fac
Compare
30a18f8 to
4089edd
Compare
mginzbur
reviewed
Sep 29, 2022
mginzbur
reviewed
Sep 29, 2022
mginzbur
reviewed
Oct 2, 2022
mginzbur
reviewed
Oct 2, 2022
| } | ||
|
|
||
| type AnalyticsModuleProccFunc interface { | ||
| GetPriority() int |
There was a problem hiding this comment.
Add here GetName() AnalyticsModuleProccFuncName
Add also type AnalyticsModuleProccFuncName string
To be used as a key for dataframe registration
mginzbur
reviewed
Oct 2, 2022
mginzbur
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.