Skip to content

fix: ic should use none instead of atom flag and free it to prevent double delete #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 14, 2023
Merged

fix: ic should use none instead of atom flag and free it to prevent double delete #277

merged 4 commits into from
Mar 14, 2023

Conversation

@ErosZy
Copy link
Contributor

@ErosZy ErosZy commented Mar 9, 2023

RT

@ErosZy ErosZy requested review from andycall and tiye March 9, 2023 06:43
@andycall
Copy link
Member

andycall commented Mar 9, 2023

Test specs needed

@ErosZy
Copy link
Contributor Author

ErosZy commented Mar 10, 2023

@andycall test_ic_atom_free.js added

@ErosZy ErosZy added this pull request to the merge queue Mar 14, 2023
Merged via the queue into main with commit 9af8bda Mar 14, 2023
@andycall andycall mentioned this pull request Mar 14, 2023
Closed
1 task
@NoahJinnn NoahJinnn mentioned this pull request May 12, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andycall andycall andycall approved these changes

+1 more reviewer

@tiye tiye tiye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ErosZy @andycall @tiye