Skip to content

feat: add repaintBoundary for animated images when using css background-images. #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

feat: add repaintBoundary for animated images when using css background-images. #557

merged 1 commit into from
Mar 11, 2024

Conversation

andycall
Copy link
Member

This PR adds a repaintBoundary to improve paint performance when a user adds animated images via the CSS background-image property.

.background-image {
  background-image: url("https://gamevip-vivofs-static.vivo.com.cn/C0KwF6zMv7Cb99us/vassets/i/2qucd7bn.gif");
  background-size: cover;
  background-repeat: no-repeat;
}
image

@andycall andycall force-pushed the feat/optimize_background_image branch from 39c1a6a to 1fcf58b Compare February 22, 2024 14:44
@andycall andycall force-pushed the feat/optimize_background_image branch from babcf35 to a43bfa2 Compare March 10, 2024 17:11
@andycall andycall added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit 39c476d Mar 11, 2024
@andycall andycall deleted the feat/optimize_background_image branch March 11, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zjt123 zjt123 zjt123 approved these changes

+1 more reviewer

@yifei8 yifei8 yifei8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andycall @zjt123 @yifei8