Skip to content

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Apr 29, 2025

Description

aws-sdk-go is being deprecated on July 31, 2025. This PR updates receiver/awsxray and finishes updating internal/aws/xray to aws-sdk-go-v2.

Link to tracking issue

Fixes #37732

Testing

I converted the existing unit tests to aws-sdk-go-v2 as well, keeping the original intent of the tests.

@atoulme
Copy link
Contributor

atoulme commented Apr 29, 2025

Please address conflicts

@mjlshen mjlshen force-pushed the 37732 branch 2 times, most recently from d2e5ed5 to a48627a Compare May 1, 2025 22:33
@atoulme
Copy link
Contributor

atoulme commented May 2, 2025

@mxiamxia and @Aneurysm9 please review

@atoulme
Copy link
Contributor

atoulme commented May 8, 2025

Please address the conflict.

@atoulme atoulme marked this pull request as draft May 8, 2025 16:00
@mjlshen mjlshen marked this pull request as ready for review May 8, 2025 16:05
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@atoulme
Copy link
Contributor

atoulme commented May 9, 2025

@mjlshen please address the conflict and we can get the changes in.

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label May 9, 2025
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjlshen!

@codeboten codeboten merged commit 9a511a8 into open-telemetry:main May 12, 2025
173 checks passed
@github-actions github-actions bot added this to the next release milestone May 12, 2025
@mjlshen mjlshen deleted the 37732 branch May 12, 2025 17:11
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
aws-sdk-go is being [deprecated on July 31,
2025](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/).
This PR updates `receiver/awsxray` and finishes updating
`internal/aws/xray` to aws-sdk-go-v2.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#37732 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
I converted the existing unit tests to aws-sdk-go-v2 as well, keeping
the original intent of the tests.

---------

Signed-off-by: Michael Shen <[email protected]>
dd-jasminesun pushed a commit to DataDog/opentelemetry-collector-contrib that referenced this pull request Jun 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
aws-sdk-go is being [deprecated on July 31,
2025](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/).
This PR updates `receiver/awsxray` and finishes updating
`internal/aws/xray` to aws-sdk-go-v2.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#37732 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
I converted the existing unit tests to aws-sdk-go-v2 as well, keeping
the original intent of the tests.

---------

Signed-off-by: Michael Shen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exporter/awsxray internal/aws ready to merge Code review completed; ready to merge by maintainers receiver/awsxray Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[receiver/awsxray] migrate to AWS v2 SDK

5 participants