Skip to content

[processor/k8sattributes] Sync k8s workload labels and annotations attributes to match semconv #39775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 31, 2025
Merged

[processor/k8sattributes] Sync k8s workload labels and annotations attributes to match semconv #39775

merged 11 commits into from
Aug 31, 2025

Conversation

odubajDT
Copy link
Contributor

Link to tracking issue

Fixes #39774

@github-actions github-actions bot added the processor/k8sattributes k8s Attributes processor label Apr 30, 2025
@odubajDT odubajDT marked this pull request as ready for review April 30, 2025 10:59
@odubajDT odubajDT requested a review from a team as a code owner April 30, 2025 10:59
ChrsMark
ChrsMark approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine introducing this feature gate already if others agree.

@github-actions github-actions bot mentioned this pull request May 6, 2025
Closed
@odubajDT odubajDT force-pushed the k8sattributesprocessor-labels-annotations branch from d66d9da to 5d647fa Compare May 7, 2025 09:50
@odubajDT odubajDT changed the title [processor/k8sattributes] Introduce allowLabelsAnnotationsSingular feature gate [processor/k8sattributes] Sync k8s workload labels and annotations attributes to match semconv May 7, 2025
@github-actions github-actions bot mentioned this pull request May 13, 2025
Closed
@odubajDT odubajDT force-pushed the k8sattributesprocessor-labels-annotations branch from 5d647fa to 1872ad5 Compare May 14, 2025 05:16
@github-actions github-actions bot mentioned this pull request May 20, 2025
Closed
@odubajDT odubajDT force-pushed the k8sattributesprocessor-labels-annotations branch from 1872ad5 to f5c47f1 Compare May 23, 2025 10:01
@github-actions github-actions bot mentioned this pull request May 27, 2025
Closed
@github-actions github-actions bot mentioned this pull request Jun 3, 2025
Closed
@odubajDT odubajDT force-pushed the k8sattributesprocessor-labels-annotations branch from f5c47f1 to 511d79c Compare June 3, 2025 09:19
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Closed
@github-actions github-actions bot mentioned this pull request Jun 17, 2025
Closed
@github-actions github-actions bot mentioned this pull request Jun 24, 2025
Closed
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 5, 2025
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
Closed
@github-actions github-actions bot mentioned this pull request Jul 15, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jul 19, 2025
@odubajDT odubajDT reopened this Aug 1, 2025
@github-actions github-actions bot removed the Stale label Aug 1, 2025
@dmitryax dmitryax merged commit 64f703f into open-telemetry:main Aug 31, 2025
186 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 31, 2025
@obs-gh-mattcotter
Copy link

Should this processor also check the feature gate when building the default tag names in the config?

opentelemetry-collector-contrib/processor/k8sattributesprocessor/options.go

Lines 230 to 252 in 1573d65

// withExtractLabels allows specifying options to control extraction of pod labels.
func withExtractLabels(labels ...FieldExtractConfig) option {
return func(p *kubernetesprocessor) error {
labels, err := extractFieldRules("labels", labels...)
if err != nil {
return err
}
p.rules.Labels = labels
return nil
}
}
// withExtractAnnotations allows specifying options to control extraction of pod annotations tags.
func withExtractAnnotations(annotations ...FieldExtractConfig) option {
return func(p *kubernetesprocessor) error {
annotations, err := extractFieldRules("annotations", annotations...)
if err != nil {
return err
}
p.rules.Annotations = annotations
return nil
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitryax dmitryax dmitryax approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

Assignees

@ArthurSens ArthurSens

Labels

processor/k8sattributes k8s Attributes processor waiting-for-code-owners

Projects

None yet

Milestone

v0.135.0

Development

Successfully merging this pull request may close these issues.

[processor/k8sattributes] Sync k8s workload labels and annotations attributes to match semconv

6 participants

@odubajDT @obs-gh-mattcotter @dmitryax @ChrsMark @atoulme @ArthurSens