[chore] [pkg/stanza] make it possible to tell emitters apart in logs #39649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
approved these changes
Apr 25, 2025
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2025
…pen-telemetry#39649) #### Description After introducing the feature gate `stanza.synchronousLogEmitter` it is not possible to tell which log emitter (SynchronousLogEmitter or BatchingLogEmitter) is being used just by looking at debug logs. This is what the operator logs look like when built on current `main` (open-telemetry@a372d05). Note the part `"operator_id": "log_emitter", "operator_type": "log_emitter"`: ```console $ otelcol-contrib-0.124.1-linux_amd64 --config config.yaml 2025-04-25T10:04:40.110+0200 info [email protected]/service.go:199 Setting up own telemetry... ... 2025-04-25T10:04:40.112+0200 info adapter/receiver.go:41 Starting stanza receiver {"otelcol.component.id": "filelog", "otelcol.component.kind": "receiver", "otelcol.signal": "logs"} 2025-04-25T10:04:40.112+0200 debug pipeline/directed.go:59 Starting operator {"otelcol.component.id": "filelog", "otelcol.component.kind": "receiver", "otelcol.signal": "logs", "operator_id": "log_emitter", "operator_type": "log_emitter"} 2025-04-25T10:04:40.112+0200 debug pipeline/directed.go:63 Started operator {"otelcol.component.id": "filelog", "otelcol.component.kind": "receiver", "otelcol.signal": "logs", "operator_id": "log_emitter", "operator_type": "log_emitter"} ``` I'm fixing this in this pull request by naming the two log emitter outputs differently. Here's what the logs look like after the change - note the part `"operator_id": "batching_log_emitter", "operator_type": "batching_log_emitter"`: ```console $ /bin/otelcontribcol_linux_amd64 --config config.yaml 2025-04-25T10:02:10.563+0200 info [email protected]/service.go:199 Setting up own telemetry... ... 2025-04-25T10:02:10.566+0200 info adapter/receiver.go:41 Starting stanza receiver {"otelcol.component.id": "filelog", "otelcol.component.kind": "receiver", "otelcol.signal": "logs"} 2025-04-25T10:02:10.566+0200 debug pipeline/directed.go:59 Starting operator {"otelcol.component.id": "filelog", "otelcol.component.kind": "receiver", "otelcol.signal": "logs", "operator_id": "batching_log_emitter", "operator_type": "batching_log_emitter"} 2025-04-25T10:02:10.566+0200 debug pipeline/directed.go:63 Started operator {"otelcol.component.id": "filelog", "otelcol.component.kind": "receiver", "otelcol.signal": "logs", "operator_id": "batching_log_emitter", "operator_type": "batching_log_emitter"} ``` And with feature gate switched on - note the part `"operator_id": "synchronous_log_emitter", "operator_type": "synchronous_log_emitter"`: ```console $ bin/otelcontribcol_linux_amd64 --config config.yaml --feature-gates=stanza.synchronousLogEmitter 2025-04-25T10:02:16.529+0200 info [email protected]/service.go:199 Setting up own telemetry... ... 2025-04-25T10:02:16.532+0200 info adapter/receiver.go:41 Starting stanza receiver {"otelcol.component.id": "filelog", "otelcol.component.kind": "receiver", "otelcol.signal": "logs"} 2025-04-25T10:02:16.532+0200 debug pipeline/directed.go:59 Starting operator {"otelcol.component.id": "filelog", "otelcol.component.kind": "receiver", "otelcol.signal": "logs", "operator_id": "synchronous_log_emitter", "operator_type": "synchronous_log_emitter"} 2025-04-25T10:02:16.532+0200 debug pipeline/directed.go:63 Started operator {"otelcol.component.id": "filelog", "otelcol.component.kind": "receiver", "otelcol.signal": "logs", "operator_id": "synchronous_log_emitter", "operator_type": "synchronous_log_emitter"} ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After introducing the feature gate
stanza.synchronousLogEmitterit is not possible to tell which log emitter (SynchronousLogEmitter or BatchingLogEmitter) is being used just by looking at debug logs.This is what the operator logs look like when built on current
main(a372d05). Note the part"operator_id": "log_emitter", "operator_type": "log_emitter":I'm fixing this in this pull request by naming the two log emitter outputs differently.
Here's what the logs look like after the change - note the part
"operator_id": "batching_log_emitter", "operator_type": "batching_log_emitter":And with feature gate switched on - note the part
"operator_id": "synchronous_log_emitter", "operator_type": "synchronous_log_emitter":