[internal/aws] Migrate k8s and xray/testdata to aws-sdk-go-v2 #39497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aneurysm9 @mxiamxia please review as codeowners |
|
@kgeckhart please address the conflicts and mark the PR ready to review again |
3bb7b25 to
4e12823
Compare
Aneurysm9
approved these changes
May 9, 2025
atoulme
approved these changes
May 9, 2025
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…elemetry#39497) #### Description Migrates all usages of the deprecated aws-sdk-go -> aws-sdk-go-v2 in the k8s and xray/testdata packages of internal/aws. These usages are small and contained compared to the other usages remaining in internal/aws. #### Link to tracking issue Related to open-telemetry#37728 #### Testing I followed https://github.com/kgeckhart/opentelemetry-collector-contrib/blob/3bb7b25d1e14524d7afdc33d4d444ebabf9bf303/internal/aws/xray/testdata/README.md to verify the xray/testdata sampleapp + sampleserver produced traces as expected.
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
…elemetry#39497) #### Description Migrates all usages of the deprecated aws-sdk-go -> aws-sdk-go-v2 in the k8s and xray/testdata packages of internal/aws. These usages are small and contained compared to the other usages remaining in internal/aws. #### Link to tracking issue Related to open-telemetry#37728 #### Testing I followed https://github.com/kgeckhart/opentelemetry-collector-contrib/blob/3bb7b25d1e14524d7afdc33d4d444ebabf9bf303/internal/aws/xray/testdata/README.md to verify the xray/testdata sampleapp + sampleserver produced traces as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates all usages of the deprecated aws-sdk-go -> aws-sdk-go-v2 in the k8s and xray/testdata packages of internal/aws. These usages are small and contained compared to the other usages remaining in internal/aws.
Link to tracking issue
Related to #37728
Testing
I followed https://github.com/kgeckhart/opentelemetry-collector-contrib/blob/3bb7b25d1e14524d7afdc33d4d444ebabf9bf303/internal/aws/xray/testdata/README.md to verify the xray/testdata sampleapp + sampleserver produced traces as expected.