Skip to content

[connector/spanmetricsconnector] add separate additional dimensions for calls and duration metrics #39134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2025
Merged

[connector/spanmetricsconnector] add separate additional dimensions for calls and duration metrics #39134

merged 3 commits into from
May 2, 2025

Conversation

Frapschen
Copy link
Contributor

Description

fix: #36805

@Frapschen Frapschen requested a review from a team as a code owner April 3, 2025 09:47
@Frapschen Frapschen requested a review from MovieStoreGuy April 3, 2025 09:47
@github-actions github-actions bot requested a review from portertech April 3, 2025 09:47
@MovieStoreGuy MovieStoreGuy changed the title [connector/spanmetricsconnector] add separate additional dmensions for calls and duration metrics [connector/spanmetricsconnector] add separate additional dimensions for calls and duration metrics Apr 8, 2025
@Frapschen
Copy link
Contributor Author

@portertech Hi please review

This was referenced Apr 15, 2025
Closed
Closed
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 24, 2025
@Frapschen Frapschen mentioned this pull request Apr 25, 2025
Merged
@github-actions github-actions bot requested a review from iblancasa April 25, 2025 18:52
@Frapschen Frapschen removed the Stale label Apr 25, 2025
@Frapschen
Copy link
Contributor Author

wait PR #39664

iblancasa
iblancasa reviewed Apr 25, 2025
View reviewed changes
@github-actions github-actions bot mentioned this pull request Apr 29, 2025
Closed
@Frapschen Frapschen requested a review from iblancasa April 29, 2025 13:27
iblancasa
iblancasa approved these changes Apr 29, 2025
View reviewed changes
connector/spanmetricsconnector/connector.go

rscAndEventAttrs.EnsureCapacity(resourceAttr.Len() + event.Attributes().Len())
resourceAttr.CopyTo(rscAndEventAttrs)
// We cannot use CopyTo because it overrides the existing keys.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep this comment because what cannot be done is to do event.Attributes().CopyTo(rscAdnEventAttrs)

Copy link
Contributor Author

@Frapschen Frapschen Apr 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.