[cmd/opampsupervisor] Emit spans for startup and message handling #38797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
# Conflicts: # cmd/opampsupervisor/supervisor/supervisor.go
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
atoulme
reviewed
Mar 28, 2025
atoulme
reviewed
Mar 28, 2025
Signed-off-by: Florian Bacher <[email protected]>
# Conflicts: # cmd/opampsupervisor/supervisor/supervisor.go
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
# Conflicts: # cmd/opampsupervisor/supervisor/supervisor.go
|
@evan-bradley both your comments are showing as outdated, I guess as the PR author @bacherfl updated the contents to address them. Please take another look. |
Signed-off-by: Florian Bacher <[email protected]>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
evan-bradley
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently WIP, need buy-in from the codeowners for the related issue, but this should serve as a PoC of the suggested enhancement
This PR adds the emission of spans for the following events:
Link to tracking issue
Fixes #38724
Testing
Added assertions to the existing e2e tests to verify the expected spans