[receiver/receivercreator] Remove backslash only before backtick #38614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Mar 13, 2025
Co-authored-by: Antoine Toulme <[email protected]>
945f62f to
cb68796
Compare
This was referenced Mar 23, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@dmitryax could you take a look plz |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Please look at the conflict - looks like your change was applied? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the code was erroneously removing backslashes before every symbol in regular expressions. This caused issues when the configuration included regular expressions. For instance:
Before:
expr: body matches "^\\{"Was incorrectly translated to:
expr: body matches "^\{"Resulting in an illegal sequence.
This pull request addresses the issue by modifying the code to only remove backslashes before the backtick symbol, ensuring proper handling of regular expressions in the configuration.
Testing
Tests added