[exporter/prometheusremotewrite] feat: prom rw exporter add support for rw2 #35888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraj Michalek <[email protected]>
ArthurSens
reviewed
Oct 21, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
exporter/prometheusremotewriteexporter/generated_component_telemetry_test.go
Outdated
Show resolved
Hide resolved
dashpole
reviewed
Oct 25, 2024
exporter/prometheusremotewriteexporter/internal/metadata/generated_telemetry.go
Show resolved
Hide resolved
dashpole
reviewed
Oct 25, 2024
exporter/prometheusremotewriteexporter/internal/metadata/generated_telemetry_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Arthur Silva Sens <[email protected]>
ywwg
reviewed
May 8, 2025
ArthurSens
reviewed
May 8, 2025
ArthurSens
approved these changes
May 8, 2025
Thank you for the patience and all the help ;). |
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…or rw2 (open-telemetry#35888) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Draft PR for adding rw2 support in the prometheus remote write exporter. Very much a draft, not full implementation of the spec with a lot of code duplication and no tests WIP. TODO: - [x] changelog entry - [x] feature flag on top of config options - [x] rip out batching for now - [x] enum instead of bool for RW2 - [x] update exporter readme - [x] Validate supported enum value set - [x] Check for TODOs - [x] unit tests - [x] going over the spec and making changes to be rw2 compliant -> follow up PR - [x] try to reduce duplicate code <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#33661 Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Juraj Michalek <[email protected]> Co-authored-by: David Ashpole <[email protected]> Co-authored-by: Arthur Silva Sens <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]>
1 task
songy23
pushed a commit
that referenced
this pull request
Jun 12, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Add test case with invalid proto message in the exporter config. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes Partially implements #33661 (when merging PR please don't close the tracing issue) Requested here #35888 (comment) <!--Describe what testing was performed and which tests were added.--> #### Testing * [x] update unit tests
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
…or rw2 (open-telemetry#35888) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Draft PR for adding rw2 support in the prometheus remote write exporter. Very much a draft, not full implementation of the spec with a lot of code duplication and no tests WIP. TODO: - [x] changelog entry - [x] feature flag on top of config options - [x] rip out batching for now - [x] enum instead of bool for RW2 - [x] update exporter readme - [x] Validate supported enum value set - [x] Check for TODOs - [x] unit tests - [x] going over the spec and making changes to be rw2 compliant -> follow up PR - [x] try to reduce duplicate code <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#33661 Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Juraj Michalek <[email protected]> Co-authored-by: David Ashpole <[email protected]> Co-authored-by: Arthur Silva Sens <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]>
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
…try#40562) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Add test case with invalid proto message in the exporter config. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes Partially implements open-telemetry#33661 (when merging PR please don't close the tracing issue) Requested here open-telemetry#35888 (comment) <!--Describe what testing was performed and which tests were added.--> #### Testing * [x] update unit tests
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
…try#40562) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Add test case with invalid proto message in the exporter config. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes Partially implements open-telemetry#33661 (when merging PR please don't close the tracing issue) Requested here open-telemetry#35888 (comment) <!--Describe what testing was performed and which tests were added.--> #### Testing * [x] update unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Draft PR for adding rw2 support in the prometheus remote write exporter.
Very much a draft, not full implementation of the spec with a lot of code duplication and no tests WIP.
TODO:
Link to tracking issue #33661
Fixes
Testing
Documentation