Skip to content

Conversation

jmichalek132
Copy link
Contributor

Description

Follow up from #35703.

Draft starting the work on adding support for remote write 2.0 in the translation package.
Adding support for translating gauges.

This is first iteration and to keep the PR small

  • we don't handle duplicate metrics
  • only support gauges
  • don't handle other labels than metric name
  • don't handle exemplars
  • don't handle metadata

Link to tracking issue #33661

Fixes

Testing

Documentation

Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

The PR is basically ready for merge to be honest, I just have a few questions and comments around tests

Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after outstanding comment is resolved

Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Oct 11, 2024
@jmichalek132 jmichalek132 changed the title feat: added translation rw2 translation for gauges feat: added prometheus rw2 translation for gauges Oct 13, 2024
@dashpole dashpole added the enhancement New feature or request label Oct 14, 2024
@andrzej-stencel andrzej-stencel merged commit 230ed5c into open-telemetry:main Oct 16, 2024
168 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 16, 2024
@jmichalek132 jmichalek132 deleted the jm-prom-translation-rw2-gauges-support-fixed branch October 16, 2024 17:00
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Follow up from open-telemetry#35703.

Draft starting the work on adding support for remote write 2.0 in the
translation package.
Adding support for translating gauges.

This is first iteration and to keep the PR small
* we don't handle duplicate metrics
* only support gauges
* don't handle other labels than metric name
* don't handle exemplars
*  don't handle metadata

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue open-telemetry#33661
Fixes

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Signed-off-by: Juraj Michalek <[email protected]>
Co-authored-by: Arthur Silva Sens <[email protected]>
Co-authored-by: David Ashpole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pkg/translator/prometheus ready to merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants