Skip to content

[exporter/elasticsearch] Set body.* for log body in OTel mode #35771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 15, 2024
Merged

[exporter/elasticsearch] Set body.* for log body in OTel mode #35771

merged 6 commits into from
Oct 15, 2024

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented Oct 14, 2024 •
edited
Loading

Description

Update OTel mode to implementation to serialize log body into body.* fields

Link to tracking issue

Testing

Documentation

@carsonip carsonip requested a review from a team as a code owner October 14, 2024 15:17
felixbarny
felixbarny approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@felixbarny felixbarny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But maybe add some tests.

@carsonip
Copy link
Contributor Author

Fixed typo and added tests

@carsonip carsonip requested a review from felixbarny October 14, 2024 17:06
lahsivjar
lahsivjar approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

felixbarny
felixbarny reviewed Oct 15, 2024
View reviewed changes
@andrzej-stencel andrzej-stencel merged commit fb114a6 into open-telemetry:main Oct 15, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 15, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
@carsonip @sbylica-splunk
[exporter/elasticsearch] Set body.* for log body in OTel mode (open-t…
9985b42 
…elemetry#35771)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Update OTel mode to implementation to serialize log body into body.*
fields

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@JaredTan95 JaredTan95 Awaiting requested review from JaredTan95

+2 more reviewers

@lahsivjar lahsivjar lahsivjar approved these changes

@felixbarny felixbarny felixbarny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmitryax dmitryax

Labels

exporter/elasticsearch

Projects

None yet

Milestone

v0.112.0

Development

Successfully merging this pull request may close these issues.

5 participants

@carsonip @lahsivjar @felixbarny @andrzej-stencel @dmitryax