Skip to content

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 4, 2024

Description

Removes cmd/oteltestbedcol from list since it has no Makefile

Link to tracking issue

Fixes #35606

@mx-psi mx-psi added the release:blocker The issue must be resolved before cutting the next release label Oct 4, 2024
@mx-psi mx-psi marked this pull request as ready for review October 4, 2024 11:15
@mx-psi mx-psi requested a review from a team as a code owner October 4, 2024 11:15
@mx-psi mx-psi requested a review from fatsheep9146 October 4, 2024 11:15
@mx-psi mx-psi merged commit 7351d28 into open-telemetry:main Oct 4, 2024
165 checks passed
@mx-psi mx-psi deleted the mx-psi/fix-tidy-on-otelcontribcol branch October 4, 2024 11:25
@github-actions github-actions bot added this to the next release milestone Oct 4, 2024
mx-psi added a commit that referenced this pull request Oct 4, 2024
…ie (#35609)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

The change in #35608 was too aggressive, this reverts the changes in
release-prepare-release.sh
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Removes `cmd/oteltestbedcol` from list since it has no Makefile

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#35606
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
…ie (open-telemetry#35609)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

The change in open-telemetry#35608 was too aggressive, this reverts the changes in
release-prepare-release.sh
ghost pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2024
)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Removes `cmd/oteltestbedcol` from list since it has no Makefile

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#35606
ghost pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2024
…ie (open-telemetry#35609)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

The change in open-telemetry#35608 was too aggressive, this reverts the changes in
release-prepare-release.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:blocker The issue must be resolved before cutting the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove-toolchain and gotidy targets fail on test distros

3 participants