Skip to content

Cgroups #29621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 16, 2024
Merged

Cgroups #29621

merged 8 commits into from
Feb 16, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 1, 2023

Description:
Adds process.cgroup resource attribute to process metrics

Link to tracking Issue:
Fixes #29282

@atoulme atoulme requested a review from dmitryax as a code owner December 1, 2023 23:03
@atoulme atoulme requested a review from a team December 1, 2023 23:03
@crobert-1
Copy link
Member

CI test is hitting a panic that looks like it's caused by this change:

--- FAIL: TestScrapeMetrics_Filtered (0.00s)
    --- FAIL: TestScrapeMetrics_Filtered/No_Filter (0.00s)
panic: interface conversion: processscraper.processHandle is *processscraper.processHandleMock, not *process.Process [recovered]
	panic: interface conversion: processscraper.processHandle is *processscraper.processHandleMock, not *process.Process

@atoulme
Copy link
Contributor Author

atoulme commented Dec 7, 2023

Yes, I need to work on this some more. The interface used doesn't work well to access fields on the struct.

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 22, 2023
@crobert-1 crobert-1 removed the Stale label Jan 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 17, 2024
@github-actions github-actions bot requested a review from braydonk January 22, 2024 06:33
@atoulme atoulme force-pushed the cgroups branch 2 times, most recently from 7c2f712 to ba19244 Compare January 22, 2024 22:57
@github-actions github-actions bot removed the Stale label Jan 23, 2024
@atoulme
Copy link
Contributor Author

atoulme commented Jan 24, 2024

Sorry, this took a long time. This is now ready for review.

andrzej-stencel
andrzej-stencel reviewed Feb 2, 2024
View reviewed changes
atoulme and others added 4 commits February 2, 2024 08:58
@atoulme @andrzej-stencel
Update .chloggen/cgroups.yaml
779b87c 
Co-authored-by: Andrzej Stencel <[email protected]>