[exporter/awss3exporter] Add the ability to assume the role provided by s3uploader.role_arn #28674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkylerRogers
approved these changes
Oct 27, 2023
|
Thank you for your contribution! Please follow the following instructions:
|
thanks @atoulme! updated as well as added some tests! |
…by s3uploader:.role_arn
atoulme
approved these changes
Oct 27, 2023
|
hey @fatsheep9146! would you like me to keep updating the branch to keep in sync with main for merge, or is that something the reviewer who merges typically will handle? |
|
hey @songy23, sorry to bother, but any chance you would be able to help me out to get this merged in? |
songy23
approved these changes
Oct 31, 2023
|
@open-telemetry/collector-contrib-maintainer this should be good to go 🙏 |
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…by s3uploader.role_arn (open-telemetry#28674) **Description:** <Describe what has changed.> Adding a feature - This feature allows role assumption for s3 exportation. It is especially useful on Kubernetes clusters that are using [IAM roles for service accounts](https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html) **Testing:** Deployed to a Kubernetes cluster as well as an EC2 instance and verified it would assume the correct role and publish logs to the respective s3 bucket. **Documentation:** README updated
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…by s3uploader.role_arn (open-telemetry#28674) **Description:** <Describe what has changed.> Adding a feature - This feature allows role assumption for s3 exportation. It is especially useful on Kubernetes clusters that are using [IAM roles for service accounts](https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html) **Testing:** Deployed to a Kubernetes cluster as well as an EC2 instance and verified it would assume the correct role and publish logs to the respective s3 bucket. **Documentation:** README updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a feature - This feature allows role assumption for s3 exportation. It is especially useful on Kubernetes clusters that are using IAM roles for service accounts
Testing:
Deployed to a Kubernetes cluster as well as an EC2 instance and verified it would assume the correct role and publish logs to the respective s3 bucket.
Documentation:
README updated