Fixes issue 27567 - tail_sampling processor metrics wrong #27568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aedac71 to
d38c719
Compare
d38c719 to
3f2bc19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes 27567
In the
tail_samplingprocessor, recordstatCountTracesSampledmetric sampling decision for each policy seperately, depending on the actual decision for that policy, instead of using thefinalDecisionfor all policies equally.Link to tracking Issue:
27567
Testing:
Send traces which match some of the defined tail_sampling policies, check the collector metrics are correct.
Documentation:
None.
Please advise if I should so anything... :)