[exporter/loadbalancingexporter] support k8s service resolver #22776
Conversation
|
|
|
@codeboten Hi 😄 I submitted a pull request a few days ago and have not heard back from you, do you need more information or have another request? Thank you for your time! |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@jpkrohling |
There was a problem hiding this comment.
Thanks for the PR @fyuan1316, pinging @jpkrohling as the code owner to review the code
There was a problem hiding this comment.
This looks really cool, thank you! There are a few comments, and I couldn't test it manually as I couldn't build this due to:
go: open /home/jpkroehling/Projects/github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector/go.mod: no such file or directory
go: open /home/jpkroehling/Projects/github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector/go.mod: no such file or directory
go test -race -timeout 300s -parallel 4 --tags="" ./...
go: open /home/jpkroehling/Projects/github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector/go.mod: no such file or directory
make: *** [Makefile.Common:98: test] Error 1
I'll give it another try once you rebase this.
There was a problem hiding this comment.
If both tests are using the same value(nil), you don't need it here.
There was a problem hiding this comment.
You can replace the if/else here with:
assert.Equal(t, tt.wantErr)There was a problem hiding this comment.
If this happens, you definitely want to know about. Log a warn here.
There was a problem hiding this comment.
done ( log warn in unsupported branch. )
There was a problem hiding this comment.
Either a Background(), or something with a timeout. Same on other similar places.
There was a problem hiding this comment.
Instead of storing a map[string]string, you could store a map[string]bool, and set this value here to true. You'd save some space with that, while still having the semantics you need.
Description:
Add k8s service resolver for exporter/loadbalancingexporter
The exporter/loadbalancingexporter component currently supports both static and dns resolvers, and does not currently support the ability to load balance pods when the collector application is running in a kubernetes environment. (Backends address discovery is achieved by monitoring kubernetes endpoints resources). This pr provides that capability.
Link to tracking Issue:
suitable for scenarios where services are located in a k8s cluster #18412
Testing:
Documentation: