Skip to content

[tiny]: Remove Trace/Metric source method that is not used anymore. #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2020
Merged

[tiny]: Remove Trace/Metric source method that is not used anymore. #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions receiver/carbonreceiver/receiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ type carbonReceiver struct {

var _ receiver.MetricsReceiver = (*carbonReceiver)(nil)

func (r *carbonReceiver) MetricsSource() string {
return "Carbon"
}

// New creates the Carbon receiver with the given configuration.
func New(
logger *zap.Logger,
Expand Down
7 changes: 0 additions & 7 deletions receiver/collectdreceiver/receiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,6 @@ func New(
return r, nil
}

const metricsSource string = "CollectD"

// MetricsSource returns the name of the trace data source.
func (cdr *collectdReceiver) MetricsSource() string {
return metricsSource
}

// StartMetricsReception starts an HTTP server that can process CollectD JSON requests.
func (cdr *collectdReceiver) Start(host component.Host) error {
cdr.Lock()
Expand Down
5 changes: 0 additions & 5 deletions receiver/sapmreceiver/trace_receiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,6 @@ func (sr *sapmReceiver) HTTPHandlerFunc(rw http.ResponseWriter, req *http.Reques
rw.Write(gzipBuffer.Bytes())
}

// TraceSource implements receiver.TraceReceiver.TraceSource() and returns a tag describing the source format
func (sr *sapmReceiver) TraceSource() string {
return traceSource
}

// StartTraceReception starts the sapmReceiver's server
func (sr *sapmReceiver) Start(host component.Host) error {
sr.mu.Lock()
Expand Down
4 changes: 0 additions & 4 deletions receiver/signalfxreceiver/receiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,6 @@ type sfxReceiver struct {

var _ receiver.MetricsReceiver = (*sfxReceiver)(nil)

func (r *sfxReceiver) MetricsSource() string {
return "SignalFx"
}

// New creates the SignalFx receiver with the given configuration.
func New(
logger *zap.Logger,
Expand Down
7 changes: 0 additions & 7 deletions receiver/zipkinscribereceiver/receiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,6 @@ func New(
return r, nil
}

const traceSource string = "Zipkin-Scribe"

// TraceSource returns the name of the trace data source.
func (r *scribeReceiver) TraceSource() string {
return traceSource
}

func (r *scribeReceiver) Start(host component.Host) error {
r.Lock()
defer r.Unlock()
Expand Down