[exporter/coralogix] Bugfix/duplicate proto #8782
Conversation
| @@ -0,0 +1,847 @@ | |||
| // Code generated by protoc-gen-gogo. DO NOT EDIT. | |||
There was a problem hiding this comment.
There should be instructions on how to regenerate this file on necessity.
@open-telemetry/collector-contrib-approvers, do you think it would make sense to have the originating proto file here as well?
There was a problem hiding this comment.
I think so long as there is a make target that can generate this code and that target includes the download of the proto, it's fine for it not to be in the repo. The genproto target in the collector core downloads the zip file of the proto before running protoc.
@ofirshmuel can you add something similar here? https://github.com/open-telemetry/opentelemetry-collector/blob/a1c539a3fe0ef4f94e5cfe5646faf16ab6a62f43/Makefile#L255
There was a problem hiding this comment.
Any idea where to find the orignal proto files?
I noticed they are not in https://github.com/coralogix/opentelemetry-cx-protobuf-api
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
| @@ -0,0 +1,847 @@ | |||
| // Code generated by protoc-gen-gogo. DO NOT EDIT. | |||
| // source: collector.proto | |||
There was a problem hiding this comment.
iam not able to find collector.proto in the entire organisation. https://github.com/search?q=org%3Acoralogix+collector.proto
There was a problem hiding this comment.
I believe they meant this: https://github.com/jaegertracing/jaeger-idl/blob/main/proto/api_v2/collector.proto
There was a problem hiding this comment.
yes seems like a modified version of it. #7931 (comment)
Description:
This bugfix for this issue (7931)
I add the coralogixpb.go to the exporter folder (like other exporters) instead of coralogix/opentelemetry-cx-protobuf-api repo.
BUT I change the generate a different proto file to prevent "duplicate proto".
I removed any mention to the previous repo in coralogixexporter folder and other files
Link to tracking Issue:
Fixes #7931
Testing:
Documentation: