Skip to content

[receiver/skywalking] Create skywalking component folder/structure #8107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Mar 2, 2022
Merged

[receiver/skywalking] Create skywalking component folder/structure #8107

merged 40 commits into from
Mar 2, 2022

Conversation

JaredTan95
Copy link
Member

Description:

1st PR: Create skywalking component folder/structure and finish factory , config unit test.

Link to tracking Issue: #7954
Testing:

Documentation:
added skywalking receiver README.md

@JaredTan95 JaredTan95 requested review from a team and pmm-sumo February 23, 2022 08:13
@pmm-sumo pmm-sumo requested a review from jpkrohling February 23, 2022 08:37
pmm-sumo
pmm-sumo reviewed Feb 23, 2022
View reviewed changes
pmm-sumo
pmm-sumo reviewed Feb 23, 2022
View reviewed changes
@JaredTan95
fix goimports order
7e171cf 
Signed-off-by: jian.tan <[email protected]>
pmm-sumo
pmm-sumo reviewed Feb 23, 2022
View reviewed changes
pmm-sumo
pmm-sumo reviewed Feb 23, 2022
View reviewed changes
pmm-sumo
pmm-sumo reviewed Feb 23, 2022
View reviewed changes
@JaredTan95
fix build
722be02
@JaredTan95
fix build
f5b6cc8
@JaredTan95
add sum
2beb6c4 
Signed-off-by: jian.tan <[email protected]>
@JaredTan95
polish
c1f948c 
Signed-off-by: jian.tan <[email protected]>
@JaredTan95
update go sum
f275ee4 
Signed-off-by: jian.tan <[email protected]>
@JaredTan95
polish go mod.
137b3ab 
Signed-off-by: jian.tan <[email protected]>
@JaredTan95
make goporto
05adcd1 
Signed-off-by: jian.tan <[email protected]>
pmm-sumo
pmm-sumo reviewed Feb 23, 2022
View reviewed changes
pmm-sumo
pmm-sumo reviewed Feb 23, 2022
View reviewed changes
pmm-sumo
pmm-sumo reviewed Feb 23, 2022
View reviewed changes
@JaredTan95
polish
3908cb3 
Signed-off-by: jian.tan <[email protected]>
@JaredTan95
fix unit test
1b78e25 
Signed-off-by: jian.tan <[email protected]>
@JaredTan95
fix typo
d802117 
Signed-off-by: jian.tan <[email protected]>
pmm-sumo
pmm-sumo reviewed Feb 24, 2022
View reviewed changes
pmm-sumo
pmm-sumo reviewed Feb 24, 2022
View reviewed changes
pmm-sumo
pmm-sumo reviewed Feb 24, 2022
View reviewed changes
pmm-sumo
pmm-sumo reviewed Feb 24, 2022
View reviewed changes
pmm-sumo
pmm-sumo reviewed Feb 24, 2022
View reviewed changes
pmm-sumo
pmm-sumo reviewed Feb 24, 2022
View reviewed changes
@JaredTan95
Copy link
Member Author

thanks @pmm-sumo again

pmm-sumo
pmm-sumo approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good for the first phase now. Lets see what @jpkrohling and others say :)

jpkrohling
jpkrohling reviewed Mar 1, 2022
View reviewed changes
@jpkrohling
Copy link
Member

This is also failing:

Using versioning file /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/versions.yaml
verifyAllModulesInSet failed: Module github.com/open-telemetry/opentelemetry-collector-contrib/receiver/skywalkingreceiver (defined in /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/skywalkingreceiver/go.mod) is not listed in any module set.

Please, go over the contribution guidelines and check which files need to be changed for new components.

@JaredTan95
Copy link
Member Author

This is also failing:

Using versioning file /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/versions.yaml
verifyAllModulesInSet failed: Module github.com/open-telemetry/opentelemetry-collector-contrib/receiver/skywalkingreceiver (defined in /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/skywalkingreceiver/go.mod) is not listed in any module set.

Please, go over the contribution guidelines and check which files need to be changed for new components.

I did not change it , especially. because this is the 1st PR and the receiver does not fully functional.
I will update this, thanks.

@JaredTan95
add version.
6e52c83 
Signed-off-by: jian.tan <[email protected]>
@JaredTan95
add com
fe680d1 
Signed-off-by: jian.tan <[email protected]>
@JaredTan95
fix com
255bf24 
Signed-off-by: jian.tan <[email protected]>
@jpkrohling jpkrohling merged commit 91a96cd into open-telemetry:main Mar 2, 2022
@JaredTan95 JaredTan95 deleted the sw_reciever branch March 2, 2022 11:36
@JaredTan95 JaredTan95 mentioned this pull request May 20, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpkrohling jpkrohling jpkrohling left review comments

+1 more reviewer

@pmm-sumo pmm-sumo pmm-sumo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tigrannajaryan tigrannajaryan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JaredTan95 @jpkrohling @pmm-sumo @tigrannajaryan