Skip to content

[receiver/hostmetrics] Add filesystem utilization #8027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 7, 2022
Merged

[receiver/hostmetrics] Add filesystem utilization #8027

merged 11 commits into from
Mar 7, 2022

Conversation

brushknight
Copy link
Contributor

Description:

  • This PR adds system.filesystem.utilization to hostmetricsreceiver

Link to tracking Issue:

Testing:

  • Current tests were updated
  • Did a sanity check with Ubuntu VM

Documentation:

  • Added to scrapper docs.

@brushknight brushknight requested a review from a team February 19, 2022 09:56
@brushknight brushknight mentioned this pull request Feb 19, 2022
Closed
4 tasks
@brushknight brushknight force-pushed the host_filesystem_utilization branch from dd053d4 to 639f408 Compare February 19, 2022 10:01
dmitryax
dmitryax reviewed Feb 21, 2022
View reviewed changes
dmitryax
dmitryax reviewed Mar 1, 2022
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM

@brushknight brushknight force-pushed the host_filesystem_utilization branch from 6ed46eb to ce38ac8 Compare March 2, 2022 11:31
@brushknight brushknight force-pushed the host_filesystem_utilization branch from ce38ac8 to ad56cd2 Compare March 2, 2022 14:00
@brushknight
Copy link
Contributor Author

Change log conflicts appear every few hours, will resolve it right before merge

@dmitryax
Copy link
Member

dmitryax commented Mar 6, 2022

Sorry for the delay. LGTM

@jpkrohling jpkrohling changed the title add hostmetricsreceiver filesystem utilization [receiver/hostmetrics] Add filesystem utilization Mar 7, 2022
@jpkrohling jpkrohling merged commit b48359b into open-telemetry:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brushknight @dmitryax @jpkrohling @tigrannajaryan