-
Notifications
You must be signed in to change notification settings - Fork 3.1k
GPU Metrics sender #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU Metrics sender #756
Conversation
* Independent go.mod * Simple Prometheus client
cmd/gpumetric/main.go
Outdated
|
||
// GPU metrics declarations | ||
var ( | ||
gpuTemp = prometheus.NewGauge(prometheus.GaugeOpts{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using otel golang?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and push things using otlp exporter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bogdandrutu sorry for delayed response. I was taking a vacation. So do you mean instrumenting with OTel Go SDK and send data with OTLP exporter to the Collector instead of Prometheus + Prometheus receiver?
Struggling with excluding CGO related source from lint, unit test and integration test because enableing CGO and its related settings such as including C header file automatically cause failure of those. |
Is this PR still in progress? If this is not being worked on I suggest to close. |
@tigrannajaryan Though this is slow for the progress, it's under implementation. As I noted in the previous comment, the hardest part is to just run this program without breaking other builds. This requires a lot of work on Makefiles. Do you have any suggestion to exclude only this binary build from others? |
I do not quite understand the question. Exclude which binary from where? |
As described in the tracked issues, the intention of this PR is to include the binary that collects GPU metrics and sends them to Collector. This binary were suggested to fall into The challenge here is that prebuilt checkers require Given that, the Makefile is pretty complex and it would be great if you could suggest the way to exclude |
I see. I haven't looked at the Makefile for a while, I won't be able to help much here. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Considering this to move binary to the independent repo as Makefile requires huge change just for this. Any other ideas to avoid build breaks with holding this binary within this repo? |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Signed-off-by: Bogdan Drutu <[email protected]>
* change otlp-example to use syncer * precommit Co-authored-by: Joshua MacDonald <[email protected]>
…y#756) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Description:
Add GPU metrics sender in Prometheus format
Link to tracking Issue:
Testing:
Documentation: