Skip to content

Conversation

ymotongpoo
Copy link
Contributor

@ymotongpoo ymotongpoo commented Aug 18, 2020

Description:
Add GPU metrics sender in Prometheus format

Link to tracking Issue:

Testing:

  • Mock testing of GPU metrics

Documentation:

  • TBA (Describe prerequisite environment to build and run the binary, how to use it with OpenTelemetry Collector)

* Independent go.mod
* Simple Prometheus client
@ymotongpoo ymotongpoo changed the title Initial commit of GPU Metrics sender GPU Metrics sender Aug 18, 2020

// GPU metrics declarations
var (
gpuTemp = prometheus.NewGauge(prometheus.GaugeOpts{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using otel golang?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and push things using otlp exporter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogdandrutu sorry for delayed response. I was taking a vacation. So do you mean instrumenting with OTel Go SDK and send data with OTLP exporter to the Collector instead of Prometheus + Prometheus receiver?

@ymotongpoo
Copy link
Contributor Author

Struggling with excluding CGO related source from lint, unit test and integration test because enableing CGO and its related settings such as including C header file automatically cause failure of those.

@ymotongpoo ymotongpoo mentioned this pull request Sep 23, 2020
@tigrannajaryan
Copy link
Member

Is this PR still in progress? If this is not being worked on I suggest to close.

@ymotongpoo
Copy link
Contributor Author

@tigrannajaryan Though this is slow for the progress, it's under implementation. As I noted in the previous comment, the hardest part is to just run this program without breaking other builds. This requires a lot of work on Makefiles. Do you have any suggestion to exclude only this binary build from others?

@tigrannajaryan
Copy link
Member

... As I noted in the previous comment, the hardest part is to just run this program without breaking other builds. This requires a lot of work on Makefiles. Do you have any suggestion to exclude only this binary build from others?

I do not quite understand the question. Exclude which binary from where?

@ymotongpoo
Copy link
Contributor Author

ymotongpoo commented Oct 6, 2020

@tigrannajaryan

As described in the tracked issues, the intention of this PR is to include the binary that collects GPU metrics and sends them to Collector. This binary were suggested to fall into cmd/ directory.

The challenge here is that prebuilt checkers require CGO_ENABLE=0 while the binary requires the flag enabled. As I tried in #393, this PR need to change Makefile to exclude the for-all target because it cause test failure regardless of the content validity and to set extra test and lint cases for this PR as well. Ditto for .circleci.yaml.

Given that, the Makefile is pretty complex and it would be great if you could suggest the way to exclude cmd/gpumetrics from the default target of tests and lint.

@tigrannajaryan
Copy link
Member

Given that, the Makefile is pretty complex and it would be great if you could suggest the way to exclude cmd/gpumetrics from the default target of tests and lint.

I see. I haven't looked at the Makefile for a while, I won't be able to help much here.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 23, 2020
@ymotongpoo
Copy link
Contributor Author

ymotongpoo commented Oct 27, 2020

Considering this to move binary to the independent repo as Makefile requires huge change just for this. Any other ideas to avoid build breaks with holding this binary within this repo?

@github-actions github-actions bot removed the Stale label Oct 27, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 4, 2020
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Nov 12, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* change otlp-example to use syncer

* precommit

Co-authored-by: Joshua MacDonald <[email protected]>
jelly-afk pushed a commit to jelly-afk/opentelemetry-collector-contrib that referenced this pull request Sep 8, 2025
…y#756)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants