fix exemplars support #6140
Merged
fix exemplars support #6140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anne-Elisabeth Lelièvre <[email protected]>
|
|
||
| key := metricKey("metricKey") | ||
| next := new(consumertest.TracesSink) | ||
| p, err := newProcessor(zap.NewNop(), cfg, next) |
There was a problem hiding this comment.
I suggest using zaptest.NewTestLogger(t) instead of the Nop logger here.
There was a problem hiding this comment.
@MovieStoreGuy done
Signed-off-by: Anne-Elisabeth Lelièvre <[email protected]>
Signed-off-by: Anne-Elisabeth Lelièvre <[email protected]>
MovieStoreGuy
approved these changes
Nov 6, 2021
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@kbrockhoff, @bogdandrutu This PR is ready for review if you have time to look at it, thanks. |
codeboten
reviewed
Nov 20, 2021
There was a problem hiding this comment.
Thanks for fixing this, pinging @albertteoh as the codeowner for this component.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
codeboten
approved these changes
Dec 1, 2021
jamesmoessis
pushed a commit
to atlassian-forks/opentelemetry-collector-contrib
that referenced
this pull request
Dec 8, 2021
* fix exemplars support Signed-off-by: Anne-Elisabeth Lelièvre <[email protected]> * switch test logger from zap.Nop to zaptest. Signed-off-by: Anne-Elisabeth Lelièvre <[email protected]> * fix lint error Signed-off-by: Anne-Elisabeth Lelièvre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anne-Elisabeth Lelièvre [email protected]
Hello, this is a fix to resolve a problem by adding exemplars to the metrics in the span metrics processor.
When I tried to send the metrics to prometheus , I got this error:
And when I tried to send to Cortex, I got this error:
By analyzing these errors, I assumed that there was a problem with the index of the exemplar data map.
So to resolve this issue, instead of adding exemplars to the a specific bucket index, I propose to simply append the exemplar data and reset the entire exemplars map so the next trace will recreate all the data structure. I have retested and everything seems to be sent correctly now on my end.