Skip to content

[pkg/datadog] remove previously deprecated logs::dump_payloads #43428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2025
+54 −9
Merged

[pkg/datadog] remove previously deprecated logs::dump_payloads #43428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2891f7b
[pkg/datadog] remove previously deprecated logs::dump_payloads
jackgopack4 Oct 10, 2025
22e7a0b
[chore] fix chloggen
jackgopack4 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .chloggen/jackgopack4-remove-datadogexporter-logs-dump_payloads copy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: exporter/datadog

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove `logs::dump_payloads` config option from `datadogexporter` config.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [43427]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: Please remove the previously deprecated `logs::dump_payloads` config option from your `datadogexporter` config.

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [user]
27 changes: 27 additions & 0 deletions .chloggen/jackgopack4-remove-pkg-datadog-logs-dump_payloads.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: deprecation

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: pkg/datadog

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove `logs::dump_payloads` config option from `pkg/datadog` config.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [43427]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [api]
4 changes: 0 additions & 4 deletions exporter/datadogexporter/factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,10 +522,6 @@ func (f *factory) createLogsExporter(
) (exporter.Logs, error) {
cfg := checkAndCastConfig(c, set.Logger)

if cfg.Logs.DumpPayloads {
set.Logger.Warn("logs::dump_payloads is not valid")
}

var pusher consumer.ConsumeLogsFunc
var logsAgent logsagentpipeline.LogsAgent
hostProvider, err := f.SourceProvider(set.TelemetrySettings, cfg.Hostname, cfg.HostnameDetectionTimeout)
Expand Down
5 changes: 0 additions & 5 deletions pkg/datadog/config/logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ type LogsConfig struct {
// If unset, the value is obtained from the Site.
confignet.TCPAddrConfig `mapstructure:",squash"`

// DumpPayloads report whether payloads should be dumped when logging level is debug.
// Note: this config option does not apply when the `exporter.datadogexporter.UseLogsAgentExporter` feature flag is enabled (now enabled by default).
// Deprecated: This config option is not supported in the Datadog Agent logs pipeline.
DumpPayloads bool `mapstructure:"dump_payloads"`

// UseCompression enables the logs agent to compress logs before sending them.
// Note: this config option does not apply when the `exporter.datadogexporter.UseLogsAgentExporter` feature flag is disabled.
UseCompression bool `mapstructure:"use_compression"`
Expand Down