[exporter/syslogexporter] Fix timestamp formatting in rfc5424 syslog messages to use microsecond precision #43211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…messages to use microsecond precision Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
andrzej-stencel
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
Thanks! Please update the component name in changelog entry, I think after #43215 we need to stick to a standard format.
|
Actually I just pushed the component name change myself. This is ready to merge when CI goes green. Thanks again Paulo! |
|
Thank you @andrzej-stencel! You're welcome 💪 |
etserend
pushed a commit
to etserend/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2025
…messages to use microsecond precision (open-telemetry#43211) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR fixes the timestamp format used for `rfc5424` format to be with the maximum of microsecond precision instead of nanosecond as defined by the [RFC5424 spec](https://www.rfc-editor.org/rfc/rfc5424#section-6). <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#43114 <!--Describe what testing was performed and which tests were added.--> #### Testing Updated tests and added a new unit test to ensure the timestamp is always exported with the maximum of microsecond precision. --------- Signed-off-by: Paulo Dias <[email protected]> Co-authored-by: Andrzej Stencel <[email protected]>
mashhurs
pushed a commit
to mashhurs/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2025
…messages to use microsecond precision (open-telemetry#43211) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR fixes the timestamp format used for `rfc5424` format to be with the maximum of microsecond precision instead of nanosecond as defined by the [RFC5424 spec](https://www.rfc-editor.org/rfc/rfc5424#section-6). <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#43114 <!--Describe what testing was performed and which tests were added.--> #### Testing Updated tests and added a new unit test to ensure the timestamp is always exported with the maximum of microsecond precision. --------- Signed-off-by: Paulo Dias <[email protected]> Co-authored-by: Andrzej Stencel <[email protected]>
tommyers-elastic
pushed a commit
to tommyers-elastic/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2025
…messages to use microsecond precision (open-telemetry#43211) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR fixes the timestamp format used for `rfc5424` format to be with the maximum of microsecond precision instead of nanosecond as defined by the [RFC5424 spec](https://www.rfc-editor.org/rfc/rfc5424#section-6). <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#43114 <!--Describe what testing was performed and which tests were added.--> #### Testing Updated tests and added a new unit test to ensure the timestamp is always exported with the maximum of microsecond precision. --------- Signed-off-by: Paulo Dias <[email protected]> Co-authored-by: Andrzej Stencel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the timestamp format used for
rfc5424format to be with the maximum of microsecond precision instead of nanosecond as defined by the RFC5424 spec.Link to tracking issue
Fixes #43114
Testing
Updated tests and added a new unit test to ensure the timestamp is always exported with the maximum of microsecond precision.