Skip to content

Migrate healthcheckextension to internal/healthcheck implementation #42791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Migrate healthcheckextension to internal/healthcheck implementation #42791

wants to merge 1 commit into from

Conversation

iblancasa
Copy link
Contributor

Follow up for #42256.

@iblancasa iblancasa requested review from a team, mwear and evan-bradley as code owners September 19, 2025 15:33
iblancasa
iblancasa commented Sep 19, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 6, 2025
@iblancasa iblancasa force-pushed the 42256 branch 7 times, most recently from d33d815 to 677e024 Compare October 6, 2025 14:34
@github-actions github-actions bot removed the Stale label Oct 7, 2025
evan-bradley
evan-bradley reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay with a review. The overall approach here looks okay to me.

@atoulme atoulme marked this pull request as draft October 8, 2025 06:24
@iblancasa iblancasa force-pushed the 42256 branch 4 times, most recently from 4f59c0b to 434411a Compare October 8, 2025 16:58
evan-bradley
evan-bradley reviewed Oct 8, 2025
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @iblancasa. Looking a bit more closely, I think we have some opportunities to simplify how we do this a little. Let me know what you think.

@iblancasa iblancasa force-pushed the 42256 branch 2 times, most recently from 9def875 to a4527ee Compare October 9, 2025 09:53
@iblancasa iblancasa marked this pull request as ready for review October 9, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley left review comments

@mwear mwear Awaiting requested review from mwear mwear is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@songy23 songy23

@MovieStoreGuy MovieStoreGuy

Labels
extension/healthcheck Health Check Extension internal/healthcheck
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iblancasa @evan-bradley @atoulme @songy23 @MovieStoreGuy