Skip to content

prom translation rw2 add support for exponential histogram #42267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 31, 2025
Merged

prom translation rw2 add support for exponential histogram #42267

merged 8 commits into from
Aug 31, 2025

Conversation

jmichalek132
Copy link
Contributor

@jmichalek132 jmichalek132 commented Aug 26, 2025 •
edited
Loading

Description

Adds support for adding exponential histograms in the RW2 translation path.

Link to tracking issue

Fixes

Partially implements #33661 (when merging PR please don't close the tracing issue)

Testing

  • Added unit test
  • e2e ran with prometheus

Review please @dashpole @ywwg @ArthurSens @krajorama @aknuds1

@jmichalek132 jmichalek132 requested review from a team and dashpole as code owners August 26, 2025 14:42
@github-actions github-actions bot requested a review from Aneurysm9 August 26, 2025 14:43
@jmichalek132 jmichalek132 mentioned this pull request Aug 11, 2025
Open
29 tasks
@jmichalek132
Copy link
Contributor Author

I am not sure test failure is related to my changes, will push a new commit to re-trigger them

=== Failed
=== FAIL: . Test_PushMetrics/WAL/invalid_type_case (1.89s)
    testing.go:1267: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\Test_PushMetricsWALinvalid_type_case1132774595\001\prom_remotewrite\00000000000000000001: The process cannot access the file because it is being used by another process.

=== FAIL: . Test_PushMetrics/WAL (0.00s)
    exporter_test.go:715: test not supported when using WAL

=== FAIL: . Test_PushMetrics (3.84s)

=== FAIL: . Test_PushMetrics/WAL/invalid_type_case (re-run 1) (1.53s)
    testing.go:1267: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\Test_PushMetricsWALinvalid_type_case2256719697\001\prom_remotewrite\00000000000000000001: The process cannot access the file because it is being used by another process.

=== FAIL: . Test_PushMetrics/WAL (re-run 1) (0.00s)
    exporter_test.go:715: test not supported when using WAL

=== FAIL: . Test_PushMetrics (re-run 1) (1.54s)

ArthurSens
ArthurSens approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment but we can ignore if I'm just speaking non-sense

@ArthurSens ArthurSens added the ready to merge Code review completed; ready to merge by maintainers label Aug 29, 2025
@atoulme atoulme merged commit fcfaf67 into open-telemetry:main Aug 31, 2025
184 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dashpole dashpole dashpole approved these changes

@ArthurSens ArthurSens ArthurSens approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@evan-bradley evan-bradley

Labels

pkg/translator/prometheusremotewrite ready to merge Code review completed; ready to merge by maintainers

Projects

None yet

Milestone

v0.135.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jmichalek132 @dashpole @ArthurSens @atoulme @evan-bradley