-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[processor/transformprocessor] Add merge_histogram_buckets OTTL function to transform processor #42012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e86218f
to
752298c
Compare
processor/transformprocessor/internal/metrics/func_merge_histogram_buckets.go
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_merge_histogram_buckets.go
Outdated
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_merge_histogram_buckets.go
Outdated
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_merge_histogram_buckets.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but before moving forward, let's wait for a second review.
@TylerHelmuth @evan-bradley @jsuereth, your review would be much appreciated here. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, just a couple questions/suggestions.
processor/transformprocessor/internal/metrics/func_merge_histogram_buckets.go
Outdated
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_merge_histogram_buckets.go
Show resolved
Hide resolved
Signed-off-by: Israel Blancas <[email protected]>
@open-telemetry/collector-contrib-maintainers can we merge this? Thanks! |
@edmocosta Based on your "LGTM" comment, I'm going to take that as an approval and will merge this. Feel free to comment here if there's additional feedback you have. |
Description
Create a
merge_histogram_buckets
OTTL function that merges two buckets.In #40280, I proposed creating a
drop_bucket
function. Dropping the bucket directly would lead to the loss of data (as it was raised in #40281).This PR implements this new function avoiding losing data and providing a more meaningful name.
Link to tracking issue
Fixes #40280
Testing
Started this program:
Checked Prometheus endpoint:
And debug exporter output: