Skip to content

Conversation

thompson-tomo
Copy link
Contributor

Description

As per readme project has been deprecated for a while and can now be removed

@thompson-tomo thompson-tomo requested review from a team and atoulme as code owners July 18, 2025 14:45
@thompson-tomo thompson-tomo marked this pull request as draft July 18, 2025 14:45
@atoulme
Copy link
Contributor

atoulme commented Jul 18, 2025

Please add a changelog, and please update the codeowners to reflect the change.

@atoulme atoulme changed the title Removal of SAPM reciever Removal of SAPM receiver Jul 18, 2025
@thompson-tomo thompson-tomo marked this pull request as ready for review July 19, 2025 01:39
@thompson-tomo thompson-tomo requested a review from dmitryax as a code owner July 19, 2025 01:39
@atoulme
Copy link
Contributor

atoulme commented Jul 21, 2025

Please take a look at the conflict.

@atoulme atoulme marked this pull request as draft July 21, 2025 04:30
@thompson-tomo thompson-tomo marked this pull request as ready for review July 21, 2025 05:32
@thompson-tomo thompson-tomo force-pushed the patch-1 branch 3 times, most recently from ea8d713 to 4fa2d7c Compare July 23, 2025 10:26
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code is out of date, please run "make gendistributions" and commit the changes in this PR.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Jul 25, 2025

@songy23

I have attempted to run the command but no matter what i try, it ends up in the same issue

make gendistributions
cd /home/james/repos/opentelemetry-collector-contrib/internal/tools && GOOS="" GOARCH="" go build -o /home/james/repos/opentelemetry-collector-contrib/.tools/githubgen -trimpath go.opentelemetry.io/build-tools/githubgen
/home/james/go/pkg/mod/go.opentelemetry.io/build-tools/[email protected]/codeowners.go:12:2: package slices is not in std (/usr/local/go/src/slices)
make: *** [Makefile.Common:59: /home/james/repos/opentelemetry-collector-contrib/.tools/githubgen] Error 1

Note i am running

go version go1.23.1 linux/amd64

Any suggestions? Or could someone contribute to this pr to resolve it?

@thompson-tomo
Copy link
Contributor Author

Awaiting additional review

@dehaansa
Copy link
Contributor

Awaiting additional review

There are some conflicts to resolve, once those are resolved and CI is happy it looks fine to me.

@thompson-tomo
Copy link
Contributor Author

@dehaansa conflicts are resolved.

@dehaansa
Copy link
Contributor

There's various CI failures, seems like a lot of strange timeouts (and a known issue with govluncheck #41967 )

@thompson-tomo
Copy link
Contributor Author

I suspect time out is environmental, do you have the ability to kick off the pipeline manually to confirm?

@codeboten
Copy link
Contributor

some more conflicts need resolving :(

@thompson-tomo
Copy link
Contributor Author

Conflicts resolved again

@atoulme
Copy link
Contributor

atoulme commented Aug 15, 2025

I still see conflicts, sorry.

@atoulme
Copy link
Contributor

atoulme commented Aug 15, 2025

You might also like to remove the receiver from contrib before we delete it here: https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml#L208

@thompson-tomo
Copy link
Contributor Author

Conflicts have been resolved.

Additional PR created as open-telemetry/opentelemetry-collector-releases#1125

@atoulme atoulme merged commit 37c961a into open-telemetry:main Sep 6, 2025
183 of 184 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 6, 2025
@thompson-tomo thompson-tomo deleted the patch-1 branch September 6, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants