-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Removal of SAPM receiver #41411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of SAPM receiver #41411
Conversation
Please add a changelog, and please update the codeowners to reflect the change. |
Please take a look at the conflict. |
ea8d713
to
4fa2d7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated code is out of date, please run "make gendistributions" and commit the changes in this PR.
I have attempted to run the command but no matter what i try, it ends up in the same issue
Note i am running
Any suggestions? Or could someone contribute to this pr to resolve it? |
Awaiting additional review |
There are some conflicts to resolve, once those are resolved and CI is happy it looks fine to me. |
@dehaansa conflicts are resolved. |
There's various CI failures, seems like a lot of strange timeouts (and a known issue with govluncheck #41967 ) |
I suspect time out is environmental, do you have the ability to kick off the pipeline manually to confirm? |
some more conflicts need resolving :( |
Conflicts resolved again |
I still see conflicts, sorry. |
You might also like to remove the receiver from contrib before we delete it here: https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml#L208 |
Conflicts have been resolved. Additional PR created as open-telemetry/opentelemetry-collector-releases#1125 |
aed859e
to
a00cc4c
Compare
Description
As per readme project has been deprecated for a while and can now be removed