[extension/filestorage] - Add an option to recover from panic if underlying file is corrupted. #40986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
reviewed
Jul 14, 2025
Those were my intentions as well. However, I came across the Essentially, it is like following piece of code: func main() {
defer func() {
err := recover() // WON'T HELP BECAUE OF PANIC INSIDE OF A GOROUTINE
fmt.Println(err)
}()
go func() {
panic("OOPS!")
}()
} |
Co-authored-by: Mikołaj Świątek <[email protected]>
swiatekm
approved these changes
Jul 15, 2025
|
@open-telemetry/collector-contrib-approvers could someone take a look here? I have an approval from the codeowner. |
braydonk
approved these changes
Jul 15, 2025
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
…rlying file is corrupted. (open-telemetry#40986) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Add an option to recreate the database from scratch. This is useful if the underlying database is corrupted and there's no way to recover from it. Ideally, we would want to `recover` from a panic. However, I came across the `panic` statements in bbolt's codebase and they are raised inside of a goroutine. Unfortunately, we [can't recover](https://go.dev/wiki/PanicAndRecover#:~:text=A%20panic%20cannot%20be%20recovered%20by%20a%20different%20goroutine) from that panic in our collector process. So, our best route here is to provide an option to the user to recreate a new database. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36840, open-telemetry#35899 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Mikołaj Świątek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option to recreate the database from scratch. This is useful if the underlying database is corrupted and there's no way to recover from it.
Ideally, we would want to
recoverfrom a panic. However, I came across thepanicstatements in bbolt's codebase and they are raised inside of a goroutine. Unfortunately, we can't recover from that panic in our collector process. So, our best route here is to provide an option to the user to recreate a new database.Link to tracking issue
Fixes #36840, #35899
Testing
Documentation