Skip to content

Conversation

iblancasa
Copy link
Contributor

@iblancasa iblancasa commented Jun 18, 2025

Description

  • Fix internal counter for the rate limiter feature
  • Added some E2E tests that can be run with a proper API key
  • Added new tests to handle this situation

Link to tracking issue

Fixes #40811

Testing

Manual test

This is the output log. You will be able to see how:

  1. The exporter tries to send data
  2. The rate limit mechanism is enabled
  3. Every try to send data will print an error explaining when the rate limiting started
  4. After the duration, the exporter tries to send data again
  5. The rate limit feature is enabled again

Configuration used:

receivers:
  otlp:
    protocols:
      grpc:
        endpoint: "localhost:4317"
exporters:
  coralogix:
    domain: "eu2.coralogix.com"
    private_key: "${env:CORALOGIX_PRIVATE_KEY_LOW_QUOTA}"
    application_name: "MyBusinessEnvironment"
    subsystem_name: "MyBusinessSystem"

    rate_limiter:
      enabled: true
      threshold: 5
      duration: 10s

service:
  pipelines:
    traces:
      receivers: [otlp]
      exporters: [coralogix]
E2E test

Log output e2e_output.log

@iblancasa iblancasa requested a review from a team as a code owner June 18, 2025 18:56
@iblancasa iblancasa requested a review from braydonk June 18, 2025 18:56
@iblancasa
Copy link
Contributor Author

@povilasv @douglascamata

Signed-off-by: Israel Blancas <[email protected]>
@iblancasa
Copy link
Contributor Author

@open-telemetry/collector-contrib-approvers can we merge this? The code owners already approved the changes.
Thanks

@braydonk braydonk added the ready to merge Code review completed; ready to merge by maintainers label Jun 20, 2025
@songy23 songy23 merged commit 39267db into open-telemetry:main Jun 20, 2025
187 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 20, 2025
Dylan-M pushed a commit to Dylan-M/opentelemetry-collector-contrib that referenced this pull request Aug 5, 2025
…40812)

#### Description
- Fix internal counter for the rate limiter feature
- Added some E2E tests that can be run with a proper API key
- Added new tests to handle this situation

#### Link to tracking issue
Fixes open-telemetry#40811

<!--Describe what testing was performed and which tests were added.-->
#### Testing
##### Manual test

This is the [output
log](https://github.com/user-attachments/files/20802604/output.txt). You
will be able to see how:
1. The exporter tries to send data
2. The rate limit mechanism is enabled
3. Every try to send data will print an error explaining when the rate
limiting started
4. After the duration, the exporter tries to send data again
5. The rate limit feature is enabled again

Configuration used:
```
receivers:
  otlp:
    protocols:
      grpc:
        endpoint: "localhost:4317"
exporters:
  coralogix:
    domain: "eu2.coralogix.com"
    private_key: "${env:CORALOGIX_PRIVATE_KEY_LOW_QUOTA}"
    application_name: "MyBusinessEnvironment"
    subsystem_name: "MyBusinessSystem"

    rate_limiter:
      enabled: true
      threshold: 5
      duration: 10s

service:
  pipelines:
    traces:
      receivers: [otlp]
      exporters: [coralogix]
```

##### E2E test
Log output
[e2e_output.log](https://github.com/user-attachments/files/20802689/e2e_output.log)

Signed-off-by: Israel Blancas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exporter/coralogix ready to merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[exporter/coralogix] Fix counter reset for rate limit feature

7 participants