[connector/routing] Copy montonic, aggregationTemporality on datapoint #40729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging, I need to know if the proposed unit tests structure used for Edit: I updated unit tests for the 3 metric types. |
|
Configurations used for tests Click to toggle contents of `config.yaml`receivers:
otlp:
protocols:
http:
endpoint: 0.0.0.0:4318
exporters:
debug:
verbosity: detailed
connectors:
routing/stage:
table:
# outbound metrics have undefined/default IsMonotonic and AggregationTemporality
- condition: 'attributes["stage"] == "production"'
context: datapoint
pipelines: [metrics/prod]
# outbound metrics have proper IsMonotonic and AggregationTemporality
# - statement: 'route()'
# pipelines: [metrics/prod]
service:
telemetry:
logs:
level: debug
pipelines:
metrics/in:
receivers: [otlp]
exporters: [routing/stage]
metrics/prod:
receivers: [routing/stage]
exporters: [debug]Click to toggle contents of `JSON payload` used with curl{
"resourceMetrics": [
{
"resource": {
"attributes": [
{
"key": "service.name",
"value": {
"stringValue": "my.service"
}
}
]
},
"scopeMetrics": [
{
"scope": {
"name": "my.library",
"version": "1.0.0",
"attributes": [
{
"key": "my.scope.attribute",
"value": {
"stringValue": "some scope attribute"
}
}
]
},
"metrics": [
{
"name": "my.counter",
"unit": "1",
"description": "I am a Counter",
"sum": {
"aggregationTemporality": 1,
"isMonotonic": true,
"dataPoints": [
{
"asDouble": 5,
"startTimeUnixNano": "1544712660300000000",
"timeUnixNano": "1544712660300000000",
"attributes": [
{
"key": "my.counter.attr",
"value": {
"stringValue": "some value"
}
},
{
"key": "stage",
"value": {
"stringValue": "production"
}
}
]
}
]
}
}
]
}
]
}
]
}Curl command curl -X POST localhost:4318/v1/metrics -H "Content-Type: application/json" -d @metrics.jsonOutputs # before:
Resource SchemaURL:
Resource attributes:
-> service.name: Str(my.service)
ScopeMetrics #0
ScopeMetrics SchemaURL:
InstrumentationScope my.library 1.0.0
InstrumentationScope attributes:
-> my.scope.attribute: Str(some scope attribute)
Metric #0
Descriptor:
-> Name: my.counter
-> Description: I am a Counter
-> Unit: 1
-> DataType: Sum
-> IsMonotonic: false
-> AggregationTemporality: Unspecified
NumberDataPoints #0
Data point attributes:
-> my.counter.attr: Str(some value)
-> stage: Str(production)
StartTimestamp: 2018-12-13 14:51:00.3 +0000 UTC
Timestamp: 2018-12-13 14:51:00.3 +0000 UTC
Value: 5.000000
# after:
Resource SchemaURL:
Resource attributes:
-> service.name: Str(my.service)
ScopeMetrics #0
ScopeMetrics SchemaURL:
InstrumentationScope my.library 1.0.0
InstrumentationScope attributes:
-> my.scope.attribute: Str(some scope attribute)
Metric #0
Descriptor:
-> Name: my.counter
-> Description: I am a Counter
-> Unit: 1
-> DataType: Sum
-> IsMonotonic: true
-> AggregationTemporality: Delta
NumberDataPoints #0
Data point attributes:
-> my.counter.attr: Str(some value)
-> stage: Str(production)
StartTimestamp: 2018-12-13 14:51:00.3 +0000 UTC
Timestamp: 2018-12-13 14:51:00.3 +0000 UTC
Value: 5.000000 |
|
I ran into this problem while designing a vendor agnostic way to do short-term and long-term storage for metrics(but also logs). This seems to fix the problem which has been plaguing me for a few days with datapoints. Thanks @r0mdau for this fix. I hope a code owner could review this in time for the next release. |
Signed-off-by: Romain Dauby <[email protected]>
Signed-off-by: Romain Dauby <[email protected]>
Signed-off-by: Romain Dauby <[email protected]>
4695009 to
865f629
Compare
mwear
approved these changes
Jun 23, 2025
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
open-telemetry#40729) #### Description When moving datapoints in the routing connector, copy - isMonotonic and AggregationTemporality for Sum - AggregationTemporality for Histogram - AggregationTemporality for ExponentialHistogram #### Link to tracking issue Fixes open-telemetry#37273 #### Testing Unit tests refactored to add those properties. --------- Signed-off-by: Romain Dauby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When moving datapoints in the routing connector, copy
Link to tracking issue
Fixes #37273
Testing
Unit tests refactored to add those properties.