-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[exporter/oracleobservability] New component: Oracle Observability Exporter #40239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/oracleobservability] New component: Oracle Observability Exporter #40239
Conversation
…porter * Go init * Add README.md and code skeleton
…porter * add oracleobservability exporter in bug_report.yaml * removed oracleobservability from builder-config.yaml
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
BackOffConfig configretry.BackOffConfig `mapstructure:"retry_on_failure"` | ||
|
||
// The authentication type to use. Supported values are: config_file or instance_principal, default is config_file. | ||
AuthType AuthenticationType `mapstructure:"auth_type"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be a friendlier config interface as a struct along the lines of:
auth:
type: config_file
oci_config:
...
return false | ||
} | ||
|
||
func (cfg *Config) Validate() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a friendlier user experience if we collected all the errors in []error
, checked as many of the rules as possible at a given time, and returned the full list of configuration failures via errors.Join
.
NumConsumers: 10, | ||
QueueSize: 1000, | ||
BlockOnOverflow: true, | ||
StorageID: &filestorage, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default should be nil
. This would assume that there is an extension in the config called file_storage
which shouldn't be assumed by default.
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
Adds new component (oracleobservabilityexporter). This is only factory and configuration PR.
Link to tracking Issue: #38244.
Documentation:
readme
metadata.yaml