Skip to content

Conversation

Kalsaria-C
Copy link

Description:

Adds new component (oracleobservabilityexporter). This is only factory and configuration PR.

Link to tracking Issue: #38244.

Documentation:

readme
metadata.yaml

…porter

* Go init
* Add README.md and code skeleton
Copy link

linux-foundation-easycla bot commented May 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label May 23, 2025
Kalsaria-C and others added 2 commits May 23, 2025 14:20
…porter

* add oracleobservability exporter in bug_report.yaml
* removed oracleobservability from builder-config.yaml
@Kalsaria-C Kalsaria-C closed this May 23, 2025
@Kalsaria-C Kalsaria-C reopened this May 23, 2025
@Kalsaria-C Kalsaria-C marked this pull request as ready for review May 23, 2025 08:56
@Kalsaria-C Kalsaria-C requested a review from a team as a code owner May 23, 2025 08:56
@Kalsaria-C Kalsaria-C requested a review from dmitryax May 23, 2025 08:56
@atoulme atoulme marked this pull request as draft May 27, 2025 18:30
@atoulme atoulme added the Sponsor Needed New component seeking sponsor label May 27, 2025
@Kalsaria-C Kalsaria-C marked this pull request as ready for review June 3, 2025 09:19
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 18, 2025
BackOffConfig configretry.BackOffConfig `mapstructure:"retry_on_failure"`

// The authentication type to use. Supported values are: config_file or instance_principal, default is config_file.
AuthType AuthenticationType `mapstructure:"auth_type"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be a friendlier config interface as a struct along the lines of:

auth:
  type: config_file
  oci_config: 
    ...

return false
}

func (cfg *Config) Validate() error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a friendlier user experience if we collected all the errors in []error, checked as many of the rules as possible at a given time, and returned the full list of configuration failures via errors.Join.

NumConsumers: 10,
QueueSize: 1000,
BlockOnOverflow: true,
StorageID: &filestorage,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should be nil. This would assume that there is an extension in the config called file_storage which shouldn't be assumed by default.

@github-actions github-actions bot removed the Stale label Jun 19, 2025
Copy link
Contributor

github-actions bot commented Jul 3, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 3, 2025
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmd/otelcontribcol otelcontribcol command Sponsor Needed New component seeking sponsor Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants