exporter/googlecloud: update the reference instead of the copy #40184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonk
reviewed
May 20, 2025
83530df to
98a83bf
Compare
There was a bug before where the copy was updated and not the reference. Signed-off-by: Ridwan Sharif <[email protected]>
98a83bf to
00b6c84
Compare
I added a reflection based test. Let me know if there is a better way I don't know about |
avilevy18
approved these changes
May 20, 2025
braydonk
approved these changes
May 21, 2025
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…telemetry#40184) Fixes open-telemetry#40186 There was a bug before where the copy was updated and not the reference. Signed-off-by: Ridwan Sharif <[email protected]> Co-authored-by: Braydon Kains <[email protected]>
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
…telemetry#40184) Fixes open-telemetry#40186 There was a bug before where the copy was updated and not the reference. Signed-off-by: Ridwan Sharif <[email protected]> Co-authored-by: Braydon Kains <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40186
There was a bug before where the copy was updated and not the reference.