[hostmetricsreceiver/networkscraper] Minor fix to the handling of con… #40175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for catching this bug. Please fill the CLA, and create a changelog entry by following the command |
…ntrack errors Pass the correct failed count when calling errors.AddPartial().
c4cb316 to
d8056f5
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Did I miss a particular step or why does this PR not get any further review? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@atoulme Is there anything else you'd like me to do? As far as I can see this PR is ready for review. |
braydonk
approved these changes
Jun 20, 2025
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
open-telemetry#40175) …ntrack errors Pass the correct failed count when calling `errors.AddPartial()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntrack errors
Pass the correct failed count when calling
errors.AddPartial().