Freakynoblegas/reject invalid queue size exporterhelper #4799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Feb 3, 2022
Comment on lines
67
to
73
| if qCfg.QueueSize < 0 { | ||
| return fmt.Errorf("queue size can't be negative") | ||
| } | ||
|
|
||
| if qCfg.Enabled && qCfg.QueueSize == 0 { | ||
| return fmt.Errorf("a 0 size queue will drop all the data") | ||
| } |
There was a problem hiding this comment.
I think if not enabled I think we should just return.
bogdandrutu
reviewed
Feb 3, 2022
mx-psi
approved these changes
Feb 4, 2022
Co-authored-by: Pablo Baeyens <[email protected]>
bogdandrutu
approved these changes
Feb 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #4799 +/- ##
==========================================
- Coverage 90.68% 90.68% -0.01%
==========================================
Files 179 179
Lines 10545 10577 +32
==========================================
+ Hits 9563 9592 +29
- Misses 763 765 +2
- Partials 219 220 +1
Continue to review full report at Codecov.
|
|
Please add a changelog entry. |
pmm-sumo
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue: 4584
Testing:
Documentation: