cli: allow multiple -focus and -skip flags #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a7ea0f to
3e32550
Compare
As an example, now instead of ... --skip one|two|three|four ... one can specify ... \ --skip one \ --skip two \ --skip three \ --skip four \ ... which helps readability and maintainability a lot in case there are many tests to skip. Fixes onsi#735 Signed-off-by: Kir Kolyshkin <[email protected]>
3e32550 to
c8b1fe7
Compare
Contributor
Author
|
@onsi PTAL |
Owner
|
whoops - sorry I missed this PR @kolyshkin . I'll take a look sometime in the next few days and merge it in. |
Owner
|
sorry for the delay - this looks good! |
This was referenced Mar 8, 2021
This was referenced Mar 16, 2021
Closed
This was referenced Mar 17, 2021
Closed
pohly
reviewed
Jul 14, 2021
|
|
||
| Context("when provided with a filter", func() { | ||
| BeforeEach(func() { | ||
| focusString = `inner|\d` |
Contributor
There was a problem hiding this comment.
This is a breaking change. Users who relied on -ginkgo.skip overwriting the old value will be surprised... I certainly was and it took me a while to figure out why some tests no longer ran.
The reason was this default:
// Skip slow or distruptive tests by default.
flag.Set("ginkgo.skip", `\[Slow|Disruptive\]`)
flag.Parse()
We overwrite that default in our Makefile, but because of this change, the skip string above remained in effect.
There was a problem hiding this comment.
+1
maybe need keep this test, keep no breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example, now instead of
one can specify
which helps readability and maintainability a lot in case there are many
tests to skip.
Fixes #735 (check it for more real-world example).