Fix data race in internal/cluster/routingtable/update.go #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a data race between routing tables update go-routines when tests are
ran with `-race` flag:
```
WARNING: DATA RACE
Write at 0x00c00040ec20 by goroutine 298:
github.com/olric-data/olric/internal/cluster/routingtable.(*RoutingTable).updateRoutingTableOnCluster.(*Members).Range.(*RoutingTable).updateRoutingTableOnCluster.func1.func2()
/home/maxim/.local/go/pkg/mod/github.com/olric-data/[email protected]/internal/cluster/routingtable/update.go:88 +0xeb
golang.org/x/sync/errgroup.(*Group).Go.func1()
/home/maxim/.local/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:93 +0x86
Previous read at 0x00c00040ec20 by goroutine 297:
github.com/olric-data/olric/internal/cluster/routingtable.(*RoutingTable).updateRoutingTableOnCluster.(*Members).Range.(*RoutingTable).updateRoutingTableOnCluster.func1.func2()
/home/maxim/.local/go/pkg/mod/github.com/olric-data/[email protected]/internal/cluster/routingtable/update.go:88 +0x12f
golang.org/x/sync/errgroup.(*Group).Go.func1()
/home/maxim/.local/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:93 +0x86
```
Same captured `err` variable is shared between several go-routines.
Collaborator
|
Thank you for your contribution. I'm going to review your previous PRs. @phmx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a data race between routing tables update go-routines when tests are ran with
-raceflag:Same captured
errvariable is shared between several go-routines.