Skip to content

[WebGPU] Update and Correct example and backend #8831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
manuel5975p wants to merge 2 commits into from
Closed

[WebGPU] Update and Correct example and backend #8831

manuel5975p wants to merge 2 commits into from

Conversation

@manuel5975p
Copy link

@manuel5975p manuel5975p commented Jul 23, 2025

  • Get both the WebGPU backend and its example up to date with the current (standardized) webgpu.h header.
    • API change for wgpuInstanceRequestAdapter
    • API change for wgpuAdapterRequestDevice
    • Some renamings, i.e. WGPUEmscriptenSurfaceSourceCanvasHTMLSelector and its sType
  • Remove dependencies on the C++ header webgpu_cpp.h as it's nonstandard and doesn't provide much benefit here

The current implementation has been tested against webgpu.h generated by chromium/7281

In the example, a glfw callback is added to correctly deal with window resizes.

However, here's some parts of this PR that are still unrefined:

  • A lot of places use #ifdef switching depending on the backend to choose a code path. This PR keeps it that way, however this should maybe be removed entirely? The only purpose of this is to deal with outdated headers of some implementations.
  • Similarly, compiling for web requires the WEBGPU_BACKEND_EMDAWNWEBGPU flag and the IMGUI_IMPL_WEBGPU_BACKEND_DAWN at the same time, which only works by commenting out an #error directive.

@manuel5975p
Update webgpu backend and example 1
d29a5f9
@manuel5975p
Update example and Makefile
f0640b8 
Makefile has been updated for the current state of emscripten, featuring --use-port=emdawnwebgpu and REMOVING -sUSE_WEBGPU=1
The example is again up to date with webgpu.h and doesn't require webgpu_cpp anymore
@ocornut
Copy link
Owner

ocornut commented Jul 30, 2025

Thanks! Linking to #8674 #8567 #8381

FYI I am struggling to take on action with any of those since they are difficult to test :(

Also, any PR which exhibit the fact that the submitting person has not carefully reviewed every line of the PR is also quite unfortunately immediately taking a huge hit in term of trust. It's difficult for me to consider reviewing a PR if I feel that I cannot trust the submitter. It's 100% certain there are useful stuff in there, which I can use as reference at minimum, but if I can spot 5 mistakes in one minute of reviewing the whole thing begins with a huge hit on trust.

@ocornut ocornut mentioned this pull request Oct 9, 2025
Closed
@ocornut
Copy link
Owner

ocornut commented Oct 9, 2025

As part of trying to untangle #8381 (funnily one PR is #8381 and the other is #8831)
I have extracted a ImGui_ImplGLFW_CreateWGPUSurface() helper function into proposed 63ef7e6., which we can refine based on your equivalent glfwCreateWindowWGPUSurface() function.

ocornut pushed a commit to BrutPitt/imgui that referenced this pull request Oct 31, 2025
@BrutPitt @ocornut
Backends: WebGPU: added ImGui_ImplWGPU_CreateWGPUSurfaceHelper(). (oc…
ad3b0ee 
…ornut#8381, ocornut#8831, ocornut#8567, ocornut#8191, ocornut#7435)
ocornut pushed a commit to BrutPitt/imgui that referenced this pull request Oct 31, 2025
@BrutPitt @ocornut
Backends: WebGPU: added smaller and debug helpers. (ocornut#8381, oco…
f273a67 
…rnut#8831, ocornut#8567, ocornut#8191, ocornut#7435)
ocornut pushed a commit that referenced this pull request Oct 31, 2025
@BrutPitt @ocornut
Backends: WebGPU: added ImGui_ImplWGPU_CreateWGPUSurfaceHelper(). (#8381
d0e3b1d 
, #8831, #8567, #8191, #7435)
ocornut pushed a commit that referenced this pull request Oct 31, 2025
@BrutPitt @ocornut
Backends: WebGPU: added smaller and debug helpers. (#8381, #8831, #8567…
c5b2a84 
…, #8191,