-
Notifications
You must be signed in to change notification settings - Fork 456
Fix runtest_alias for inline tests #12324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
approved these changes
Aug 28, 2025
Collaborator
|
The windows job is unrelated, it started failing before this PR. |
Signed-off-by: Jérôme Vouillon <[email protected]>
…e-tests) Signed-off-by: Jérôme Vouillon <[email protected]>
0c10f32 to
d1eb94b
Compare
Collaborator
|
cc @maiste This will need to go in a |
maiste
added a commit
that referenced
this pull request
Sep 1, 2025
Signed-off-by: Jérôme Vouillon <[email protected]> Co-authored-by: Jérôme Vouillon <[email protected]> Co-authored-by: Ali Caglayan <[email protected]>
maiste
added a commit
to maiste/opam-repository
that referenced
this pull request
Sep 3, 2025
CHANGES: ### Fixed - Fix jsoo separate compilation with modules_without_implementation. Regression introduced in ocaml/dune#10767. (ocaml/dune#12320, fixes ocaml/dune#12306 @hhugo) - Fix `runtest-js` mistakenly using wrong dependencies (ocaml/dune#12324, @vouillon) - Remove empty `.cram.test.t` directory during the running of a cram test. (ocaml/dune#12329, fixes ocaml/dune#12321, @Alizter) - Fix Cygwin bootstrap (ocaml/dune#12325, fixes ocaml/dune#12316, @Alizter)
rgrinberg
added a commit
that referenced
this pull request
Nov 28, 2025
Release 3.20.2 CHANGES: - Fix jsoo separate compilation with modules_without_implementation. Regression introduced in #10767. (#12320, fixes #12306 @hhugo) - Fix `runtest-js` mistakenly using wrong dependencies (#12324, @vouillon) - Remove empty `.cram.test.t` directory during the running of a cram test. (#12329, fixes #12321, @Alizter) - Fix Cygwin bootstrap (#12325, fixes #12316, @Alizter) Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
added a commit
that referenced
this pull request
Nov 28, 2025
Release 3.20.2 CHANGES: - Fix jsoo separate compilation with modules_without_implementation. Regression introduced in #10767. (#12320, fixes #12306 @hhugo) - Fix `runtest-js` mistakenly using wrong dependencies (#12324, @vouillon) - Remove empty `.cram.test.t` directory during the running of a cram test. (#12329, fixes #12321, @Alizter) - Fix Cygwin bootstrap (#12325, fixes #12316, @Alizter) Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
added a commit
that referenced
this pull request
Nov 28, 2025
Release 3.20.2 CHANGES: - Fix jsoo separate compilation with modules_without_implementation. Regression introduced in #10767. (#12320, fixes #12306 @hhugo) - Fix `runtest-js` mistakenly using wrong dependencies (#12324, @vouillon) - Remove empty `.cram.test.t` directory during the running of a cram test. (#12329, fixes #12321, @Alizter) - Fix Cygwin bootstrap (#12325, fixes #12316, @Alizter) Signed-off-by: Rudi Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #12242