Skip to content

Conversation

@vouillon
Copy link
Member

Similar to #12242

@Alizter
Copy link
Collaborator

Alizter commented Aug 28, 2025

The windows job is unrelated, it started failing before this PR.

@Alizter Alizter merged commit 8b2af2c into ocaml:main Aug 28, 2025
9 checks passed
@vouillon vouillon deleted the inline-tests-fix branch August 28, 2025 10:30
@Alizter
Copy link
Collaborator

Alizter commented Aug 28, 2025

cc @maiste This will need to go in a 3.20.2. Let's start collecting PRs for that. I have a few other fixes I am working on. We can wait a little longer for this one so that we can make sure we have most of the regressions caught this time.

@Alizter Alizter mentioned this pull request Aug 28, 2025
9 tasks
maiste added a commit that referenced this pull request Sep 1, 2025
Signed-off-by: Jérôme Vouillon <[email protected]>
Co-authored-by: Jérôme Vouillon <[email protected]>
Co-authored-by: Ali Caglayan <[email protected]>
maiste added a commit to maiste/opam-repository that referenced this pull request Sep 3, 2025
CHANGES:

### Fixed

- Fix jsoo separate compilation with modules_without_implementation. Regression
  introduced in ocaml/dune#10767. (ocaml/dune#12320, fixes ocaml/dune#12306 @hhugo)

- Fix `runtest-js` mistakenly using wrong dependencies (ocaml/dune#12324, @vouillon)

- Remove empty `.cram.test.t` directory during the running of a cram test.
  (ocaml/dune#12329, fixes ocaml/dune#12321, @Alizter)

- Fix Cygwin bootstrap (ocaml/dune#12325, fixes ocaml/dune#12316, @Alizter)
rgrinberg added a commit that referenced this pull request Nov 28, 2025
Release 3.20.2

CHANGES:

- Fix jsoo separate compilation with modules_without_implementation. Regression
  introduced in #10767. (#12320, fixes #12306 @hhugo)

- Fix `runtest-js` mistakenly using wrong dependencies (#12324, @vouillon)

- Remove empty `.cram.test.t` directory during the running of a cram test.
  (#12329, fixes #12321, @Alizter)

- Fix Cygwin bootstrap (#12325, fixes #12316, @Alizter)

Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg added a commit that referenced this pull request Nov 28, 2025
Release 3.20.2

CHANGES:

- Fix jsoo separate compilation with modules_without_implementation. Regression
  introduced in #10767. (#12320, fixes #12306 @hhugo)

- Fix `runtest-js` mistakenly using wrong dependencies (#12324, @vouillon)

- Remove empty `.cram.test.t` directory during the running of a cram test.
  (#12329, fixes #12321, @Alizter)

- Fix Cygwin bootstrap (#12325, fixes #12316, @Alizter)

Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg added a commit that referenced this pull request Nov 28, 2025
Release 3.20.2

CHANGES:

- Fix jsoo separate compilation with modules_without_implementation. Regression
  introduced in #10767. (#12320, fixes #12306 @hhugo)

- Fix `runtest-js` mistakenly using wrong dependencies (#12324, @vouillon)

- Remove empty `.cram.test.t` directory during the running of a cram test.
  (#12329, fixes #12321, @Alizter)

- Fix Cygwin bootstrap (#12325, fixes #12316, @Alizter)

Signed-off-by: Rudi Grinberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants