Skip to content

Conversation

@john-macedo
Copy link

@john-macedo john-macedo commented Jun 9, 2023

Initial checks

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linked an issue to this pull request? (Create one if it does not exist)
  • Have you used Conventional Commits format?

[SUGGESTION]

Description

Add support for mutualTLS security handler #377

Implementation details

Implemented in src/middleware/native/oas-security.js. Add a new case statement for 'mutualTLS', that extracts peer (client-side) TLS certificate (full chain) and invokes the corresponding security handler with the certificate object as a parameter.

@coveralls
Copy link

coveralls commented Jun 9, 2023

Pull Request Test Coverage Report for Build 5226680199

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 10 (20.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 91.282%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/middleware/native/oas-security.js 2 10 20.0%
Totals Coverage Status
Change from base Build 4349638879: -0.6%
Covered Lines: 893
Relevant Lines: 955

💛 - Coveralls

@alesancor1 alesancor1 merged commit 09623c0 into oas-tools:develop Jul 17, 2023
@alesancor1 alesancor1 linked an issue Jul 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SUGESTION] Add support for mutualTLS security handler

3 participants