fix(vite): enable build watch mode by default for preview (#31604) #31623
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
a7e6760 to
bfb7574
Compare
|
cc @mandarini |
Coly010
approved these changes
Jun 27, 2025
|
View your CI Pipeline Execution ↗ for commit 751d8d6
☁️ Nx Cloud last updated this comment at |
bfb7574 to
85e729e
Compare
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 751d8d6 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
85e729e to
9a47324
Compare
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
We've fixed the TypeScript compilation error in the preview-server executor. The issue was using {} as the default value for the watch option when it should be a boolean true to match the ViteBuildExecutorOptions type definition.
We verified this fix by re-running vite:build-base.
diff --git a/packages/vite/src/executors/preview-server/preview-server.impl.ts b/packages/vite/src/executors/preview-server/preview-server.impl.ts
index 495c063bca..edc5315814 100644
--- a/packages/vite/src/executors/preview-server/preview-server.impl.ts
+++ b/packages/vite/src/executors/preview-server/preview-server.impl.ts
@@ -57,7 +57,7 @@ export async function* vitePreviewServerExecutor(
...buildTargetOptions,
...{
// Enable watch mode by default for the build target.
- watch: options.watch ?? {},
+ watch: options.watch ?? true,
},
});
Apply fix locally ↗ View interactive diff ↗
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
9a47324 to
751d8d6
Compare
leosvelperez
approved these changes
Oct 8, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Oct 8, 2025
…31623) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> `nx preview <app>` does not enable watch mode on the build. This used to be the case until (I think) #20367 ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> `nx preview <app>` should also enable watch mode and rebuild on files change. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> FYI: I also had to apply [this config change](vitejs/vite#19410 (comment)) for Vite 6 to unstuck from "Rebuilding project...". Maybe it's just my project, not sure but in any case those are 2 separate issues. Fixes #31604 (cherry picked from commit 8f8f804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
nx preview <app>does not enable watch mode on the build.This used to be the case until (I think) #20367
Expected Behavior
nx preview <app>should also enable watch mode and rebuild on files change.Related Issue(s)
FYI: I also had to apply this config change for Vite 6 to unstuck from "Rebuilding project...". Maybe it's just my project, not sure but in any case those are 2 separate issues.
Fixes #31604