linux_wayland, linux_x11: Fixed cursor flickering when show_mouse() is used with non-default cursor. #595
+22
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s used with a non-default cursor. This addresses cursor flickering in egui-miniquad-0.16.0. NOTE: This changes behavior of set_cursor(), it won't show reveal a hidden cursor on X11 and Wayland anymore. But the new behavior is consistent with Windows. The problem is that neither Wayland nor X11 backend tracks cusor visibility separately from the icon. Every time the cursor is shown it is being reset to default cursor. And whenever cursor is changed it is being shown. This is different from Windows, where SetCursor() is independent from ShowCursor(). To address I track these states explicitly in native::linux_wayland::run() and X11Display. Test steps: * Run X11 session * Run demo example from egui-miniquad-0.16.0 * Try resizing an egui window and observe cursor not flickering anymore. * Run Wayland session in Plasma 6.5.3 * Modify conf of demo to run on Wayland (default is X11) * Try resizing an egui window and observe cursor not flickering anymore.
Owner
|
Thanks for PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses cursor flickering in egui-miniquad-0.16.0.
See not-fl3/egui-miniquad#47
NOTE: This changes behavior of set_cursor(), it won't show the hidden the cursor on X11 and Wayland anymore. This is now consistent with Windows.
The problem is that neither Wayland nor X11 backend tracks cursor visibility separately from the icon. Every time the cursor is shown it is being reset to default cursor. And whenever cursor is changed it is being shown. This is different from Windows, where SetCursor() is independent from ShowCursor().
To address I track these states explicitly in native::linux_wayland::run() and X11Display.
Test steps: